Issue metadata
Sign in to add a comment
|
glGenerateMipmap fails if texture base level is not set |
||||||||||||||||||||
Issue descriptionChrome Version : 58.0.2873.0 OS version : MAC OS X 10.12.4 tex-mipmap-levels.html fails since mac os update to 10.12.4. GenerateMipmap fails when texture mipmap level 0 is not set. A mac workaround is to set the level 0 (BUG= 560499 ),but here's a regression. The output is (0,0,0,255) which is not as expected. A bug of texImage2D is tracked from this regression. First, Set texture base level > 0, then set texture level 0 result in pixel comparison error of its base level. We can work around this issue by temporarily setting base level to 0 before texImage2D,and recover the base level after that. WebGL Test: conformance2/textures/misc/tex-mipmap-levels.html conformance2/textures/misc/tex-base-level-bug.html
,
Mar 28 2017
,
Mar 29 2017
,
Mar 29 2017
,
Mar 29 2017
This sounds familiar. Do we already have a radar filed before and this regressed a second time?
,
Mar 29 2017
Mo, I think the bug you're thinking of is Issue 640506 . That one affected glTexStorage2D on multiple GPU types. It does look like Brandon added a workaround for this particular bug in Issue 560499 some time ago. We should file a Radar about this. We should also work with Apple to get the WebGL 2.0 conformance suite running in house on their side.
,
Apr 20 2017
,
Apr 25 2017
I'm surprised to see that this new conformance test https://github.com/KhronosGroup/WebGL/pull/2378 fails on Windows too, but I can't see anything wrong with the test, after reviewing all of the spec text around texture completeness and the usage of the TEXTURE_BASE_LEVEL and TEXTURE_MAX_LEVEL parameters.
,
Apr 25 2017
,
Apr 25 2017
,
Apr 25 2017
Have a fix up for ANGLE D3D11: https://chromium-review.googlesource.com/c/486107/
,
Apr 25 2017
That's excellent Geoff. Thanks for the quick fix and confirming that this was in fact a bug in ANGLE.
,
Apr 25 2017
For what it's worth, this also seems to fail on the Windows AMD OpenGL driver.
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/66c5e619fcf202d22aa4f448b38f1fd1e9331516 commit 66c5e619fcf202d22aa4f448b38f1fd1e9331516 Author: Geoff Lang <geofflang@chromium.org> Date: Tue Apr 25 18:11:56 2017 TextureD3D: Mark images dirty after deleting the texture storage. When a texture storage is deleted, it copies its mip levels back into images and marks them clean. Marking the images dirty before deleting the texture storage would have no effect. BUG=705865 Change-Id: Ib4c0fc9bea1236fc31963d1b7db814785bc54abc Reviewed-on: https://chromium-review.googlesource.com/486107 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/66c5e619fcf202d22aa4f448b38f1fd1e9331516/src/libANGLE/renderer/d3d/TextureD3D.cpp [modify] https://crrev.com/66c5e619fcf202d22aa4f448b38f1fd1e9331516/src/tests/gl_tests/MipmapTest.cpp
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/2aadbfc3899e5cb656df61c2b98fcc588d85b513 commit 2aadbfc3899e5cb656df61c2b98fcc588d85b513 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Apr 27 15:27:36 2017 Expand the MipmapTestES3.BaseLevelTextureBug supression to all AMD OpenGL. BUG=705865 BUG= 715875 Change-Id: Ib4d83a8c9cb3f65ac8517bfd3ff7c38794dd0654 Reviewed-on: https://chromium-review.googlesource.com/488661 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/2aadbfc3899e5cb656df61c2b98fcc588d85b513/src/tests/gl_tests/MipmapTest.cpp
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa0a7e66dd1583ab71436f26ee362278437e1972 commit fa0a7e66dd1583ab71436f26ee362278437e1972 Author: ynovikov <ynovikov@chromium.org> Date: Fri Apr 28 03:55:49 2017 Roll ANGLE f584177..e8b3551 https://chromium.googlesource.com/angle/angle.git/+log/f584177..e8b3551 BUG= 715875 ,705865 TBR=jmadill@chromium.org, geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2849583003 Cr-Commit-Position: refs/heads/master@{#467881} [modify] https://crrev.com/fa0a7e66dd1583ab71436f26ee362278437e1972/DEPS
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b96dfa5b9c0656cc9a8dc0e67f1ab3b547c45a84 commit b96dfa5b9c0656cc9a8dc0e67f1ab3b547c45a84 Author: findit-for-me <findit-for-me@appspot.gserviceaccount.com> Date: Fri Apr 28 04:52:10 2017 Revert of Roll ANGLE f584177..e8b3551 (patchset #1 id:1 of https://codereview.chromium.org/2849583003/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 467881 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZhMGE3ZTY2ZGQxNTgzYWI3MTQzNmYyNmVlMzYyMjc4NDM3ZTE5NzIM Original issue's description: > Roll ANGLE f584177..e8b3551 > > https://chromium.googlesource.com/angle/angle.git/+log/f584177..e8b3551 > > BUG= 715875 ,705865 > TBR=jmadill@chromium.org, geofflang@chromium.org > > TEST=bots > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2849583003 > Cr-Commit-Position: refs/heads/master@{#467881} > Committed: https://chromium.googlesource.com/chromium/src/+/fa0a7e66dd1583ab71436f26ee362278437e1972 TBR=jmadill@chromium.org,geofflang@chromium.org,ynovikov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 715875 ,705865 Review-Url: https://codereview.chromium.org/2846763004 Cr-Commit-Position: refs/heads/master@{#467886} [modify] https://crrev.com/b96dfa5b9c0656cc9a8dc0e67f1ab3b547c45a84/DEPS
,
Apr 28 2017
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8eefcd377d3600ba7ed04f0ab65ce3b3f08e75d commit d8eefcd377d3600ba7ed04f0ab65ce3b3f08e75d Author: kbr <kbr@chromium.org> Date: Fri Apr 28 22:11:00 2017 Temporarily suppress tex-base-level-bug failure on Windows with D3D11. This is only needed until the next ANGLE roll. BUG=705865, 716432 TBR=geofflang@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2849863003 Cr-Commit-Position: refs/heads/master@{#468151} [modify] https://crrev.com/d8eefcd377d3600ba7ed04f0ab65ce3b3f08e75d/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4fcf211213e19d716f822cc514da06155879926 commit d4fcf211213e19d716f822cc514da06155879926 Author: kbr <kbr@chromium.org> Date: Fri Apr 28 23:23:17 2017 Suppress test failures new in 10.12.4. BUG=705865,715366, 716652 TBR=zmo@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2848123002 Cr-Commit-Position: refs/heads/master@{#468178} [modify] https://crrev.com/d4fcf211213e19d716f822cc514da06155879926/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Apr 28 2017
The ANGLE MipmapTestES3.BaseLevelTextureBug test is failing on 10.12.4, on at least NVIDIA GPUs; probably Intel as well (otherwise this wouldn't have been discovered by Intel's Web GPU team). See: https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Experimental%20Retina%20Release%20%28NVIDIA%29/builds/941 Adding suppressions to ANGLE.
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/e7a792c624b882a6b4c0a494e998cb51503b414a commit e7a792c624b882a6b4c0a494e998cb51503b414a Author: Kenneth Russell <kbr@chromium.org> Date: Mon May 01 15:29:09 2017 Suppress MipmapTestES3.BaseLevelTextureBug failures on 10.12.4. BUG=705865 Change-Id: Ife59aaf009365a51b5362a00373d1efaceba9fb8 Reviewed-on: https://chromium-review.googlesource.com/490946 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/e7a792c624b882a6b4c0a494e998cb51503b414a/src/tests/gl_tests/MipmapTest.cpp
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ad94eb92a8269ec545b6ef30c4311f8125d6f22 commit 8ad94eb92a8269ec545b6ef30c4311f8125d6f22 Author: jmadill <jmadill@chromium.org> Date: Mon May 01 16:12:46 2017 Suppress two WebGL 2 test failures on Linux AMD. BUG=705865 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2851203002 Cr-Commit-Position: refs/heads/master@{#468320} [modify] https://crrev.com/8ad94eb92a8269ec545b6ef30c4311f8125d6f22/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
May 1 2017
Before closing this bug as fixed: please make sure ANGLE has rolled forward and that the suppression that was added in d8eefcd377d3600ba7ed04f0ab65ce3b3f08e75d is removed. Please make sure that https://build.chromium.org/p/client.v8.fyi/builders/Win%20Release%20%28NVIDIA%29 is still green after removing the suppression. Thanks.
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4431f66ad417e06c51a14b0e29d8834514bbf04 commit f4431f66ad417e06c51a14b0e29d8834514bbf04 Author: jmadill <jmadill@chromium.org> Date: Mon May 01 21:55:14 2017 Roll ANGLE f584177..d262799 https://chromium.googlesource.com/angle/angle.git/+log/f584177..d262799 BUG=chromium:716323, 715875 ,705865 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2851303002 Cr-Commit-Position: refs/heads/master@{#468436} [modify] https://crrev.com/f4431f66ad417e06c51a14b0e29d8834514bbf04/DEPS
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ac9902a04fadaa7e3f307cee39659578e53fe18 commit 1ac9902a04fadaa7e3f307cee39659578e53fe18 Author: zmo <zmo@chromium.org> Date: Fri Jun 09 04:56:41 2017 Update WebGL2 conformance test expectations for Win bots BUG= 491419 , 614418 ,662644, 676848 ,680754,693090,705865, 709484 TEST=GPU FYI bots TBR=kbr@chromium.org,kainino@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2927233002 Cr-Commit-Position: refs/heads/master@{#478203} [modify] https://crrev.com/1ac9902a04fadaa7e3f307cee39659578e53fe18/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Jun 15 2017
Filed as Radar 32803036.
,
Jun 20 2017
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4541e263eea48f1f2d2c35d9d7427c88ddba718 commit c4541e263eea48f1f2d2c35d9d7427c88ddba718 Author: JiangYizhou <yizhou.jiang@intel.com> Date: Mon Aug 14 18:09:44 2017 Reset TexImage2D base level to workaround Intel mac driver bug. If texture's base level is not 0, update texture, level 0 will result in wrong pixel of base level image. To workaround the bug, we could reset texture base level to 0 before texImage2D and recover base level later. BUG=705865 TEST=conformance2/textures/misc/tex-base-level-bug.html TEST=conformance2/textures/misc/tex-mipmap-levels.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel patch from issue 2827573007 at patchset 240001 (http://crrev.com/2827573007#ps240001) Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifba2fe1aab4a6cbec203a0662010e49fb595ee64 Reviewed-on: https://chromium-review.googlesource.com/597504 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#494099} [modify] https://crrev.com/c4541e263eea48f1f2d2c35d9d7427c88ddba718/gpu/config/gpu_driver_bug_list.json [modify] https://crrev.com/c4541e263eea48f1f2d2c35d9d7427c88ddba718/gpu/config/gpu_driver_bug_workaround_type.h [modify] https://crrev.com/c4541e263eea48f1f2d2c35d9d7427c88ddba718/gpu/ipc/service/gpu_command_buffer_stub.cc [modify] https://crrev.com/c4541e263eea48f1f2d2c35d9d7427c88ddba718/ui/gl/gl_gl_api_implementation.cc [modify] https://crrev.com/c4541e263eea48f1f2d2c35d9d7427c88ddba718/ui/gl/gl_workarounds.h
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6 commit a5f88b7e35a567c40e25e21b285ec7e8c687e6d6 Author: James Darpinian <jdarpinian@chromium.org> Date: Mon Nov 12 23:09:19 2018 Cleaning up WebGL test failure expectations. Many of these are leftover failure expectations from fixed bugs. Some were fixed on some platforms but not others. There are some new failures that were hidden by previous broad suppressions. Also some tests are only failing because we haven't updated the drivers on the bots (http://crbug.com/887241). Bug: 757097 , 838133 , 672380 , 625738, angleproject:2325 Bug: 534697 , 849572, 625738, 703779, angleproject:2142 Bug: 757098, 644740, 705865, 602688, angleproject:2103 Bug: 903903, 740769 , 662644, 680720 , angleproject:1932 Bug: 709874 , 887241, 625365 , angleproject:2952 Change-Id: I4e39e5a09d31d788d8a8615ad06d1ec88f064f00 Reviewed-on: https://chromium-review.googlesource.com/c/1325197 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607367} [modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by yizhou.j...@intel.com
, Mar 28 2017Owner: yizhou.j...@intel.com