Issue metadata
Sign in to add a comment
|
Regression: On changing browser language to 'German', summary for 'Automatic Downloads' is missing in chrome://md-settings/content.
Reported by
aiman.an...@etouch.net,
Mar 28 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3053.3 (Official Build) d06aedb601e668067132026a8f14fe0179697b50-refs/branch-heads/3053@{#4}(32/64 Bit). OS: Windows(7,8,10). Steps to reproduce: 1.Launch Chrome, go to chrome://md-settings, change browser language to 'German' from chrome://md-settings/languages. 2. Relaunch chrome, go to chrome://md-settings/content, scroll down and observe. Actual Result: Summary for Automatic Downloads is missing. Expected Result: Summary for Automatic Downloads should appear. This is regression issue broken in 'M 58' and will soon update the bisect info: Manual Bisect Info: Good Build 58.0.2994.0 Bad Build 58.0.2995.0 Note: Issue is not reproducible on Linux and Mac OS.
,
Apr 14 2017
,
Apr 14 2017
,
Apr 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdf55422a65db1c91c48ba50e952f9a1804bbb1a commit cdf55422a65db1c91c48ba50e952f9a1804bbb1a Author: dschuyler <dschuyler@chromium.org> Date: Fri Apr 14 18:15:44 2017 [i18n] escape commas, polymer workaround The Polymer binding parser treats commas and escaped commas as special. This CL escapes commas so they are handled properly with Polymer. (Without this CL the binding is ignored if an un-escaped comma is present). BUG= 705850 Review-Url: https://codereview.chromium.org/2818053002 Cr-Commit-Position: refs/heads/master@{#464753} [modify] https://crrev.com/cdf55422a65db1c91c48ba50e952f9a1804bbb1a/ui/base/template_expressions.cc
,
Apr 14 2017
,
Apr 14 2017
,
Apr 14 2017
This bug requires manual review: We don't branch M59 until 2017-04-13. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b6a1ef9682320bdfc2bf9a604ec98b92d3f7ac0 commit 8b6a1ef9682320bdfc2bf9a604ec98b92d3f7ac0 Author: dschuyler <dschuyler@chromium.org> Date: Fri Apr 14 21:07:54 2017 [i18n] unit test for commas in Polymer This adds unit test for escaping commas in Polymer strings. Related to https://codereview.chromium.org/2818053002/ BUG= 705850 Review-Url: https://codereview.chromium.org/2814273005 Cr-Commit-Position: refs/heads/master@{#464794} [modify] https://crrev.com/8b6a1ef9682320bdfc2bf9a604ec98b92d3f7ac0/ui/base/template_expressions_unittest.cc
,
Apr 19 2017
Thanks - can you please confirm if this has been well tested in Canary, verified, and if there is enough unit test coverage for this change?
,
Apr 20 2017
Tested the issue on Windows-10 & 7 using chrome latest Canary M60-60.0.3075.0 by following steps mentioned in the original comment. Observed that Automatic Downloads of summary is displaying as expected. Hence adding TE-Verified label. Please find the screen shot for your reference. Thank you!
,
Apr 20 2017
After confirming that it's tested in canary, and unit tests are added in #8, approving merge for M59.
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0419a2b67cc65c1b1dd462c2eeeaf0a25de87341 commit 0419a2b67cc65c1b1dd462c2eeeaf0a25de87341 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Apr 20 18:38:58 2017 [i18n] escape commas, polymer workaround The Polymer binding parser treats commas and escaped commas as special. This CL escapes commas so they are handled properly with Polymer. (Without this CL the binding is ignored if an un-escaped comma is present). BUG= 705850 Review-Url: https://codereview.chromium.org/2818053002 Cr-Commit-Position: refs/heads/master@{#464753} (cherry picked from commit cdf55422a65db1c91c48ba50e952f9a1804bbb1a) Review-Url: https://codereview.chromium.org/2834573004 . Cr-Commit-Position: refs/branch-heads/3071@{#92} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/0419a2b67cc65c1b1dd462c2eeeaf0a25de87341/ui/base/template_expressions.cc
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d70d39e251a031a5a0daa70445d3f78ff704b355 commit d70d39e251a031a5a0daa70445d3f78ff704b355 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Apr 20 18:40:16 2017 [i18n] unit test for commas in Polymer This adds unit test for escaping commas in Polymer strings. Related to https://codereview.chromium.org/2818053002/ BUG= 705850 Review-Url: https://codereview.chromium.org/2814273005 Cr-Commit-Position: refs/heads/master@{#464794} (cherry picked from commit 8b6a1ef9682320bdfc2bf9a604ec98b92d3f7ac0) Review-Url: https://codereview.chromium.org/2829833005 . Cr-Commit-Position: refs/branch-heads/3071@{#93} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/d70d39e251a031a5a0daa70445d3f78ff704b355/ui/base/template_expressions_unittest.cc
,
Apr 25 2017
Rechecked the issue on Windows-10 Laptop using chrome version 59.0.3071.25 by following steps mentioned in the original comment. Observed that Automatic Downloads of summary is displaying as expected. Hence adding TE-Verified label. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Mar 28 2017Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)