New issue
Advanced search Search tips

Issue 705847 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tracing error on Android due to multiple CrGpuMain threads

Project Member Reported by johnchen@chromium.org, Mar 28 2017

Issue description

While porting Android media performance benchmarks to TBMv2, I occasionally encountered the following exception:

TraceImportError: Expected no more than one CrGpuMain
at Process.findAtMostOneThreadNamed (/tracing/model/process_base.html:175:15)
at ChromeGpuHelper.isGpuProcess (/tracing/model/helpers/chrome_gpu_helper.html:30:20)
at Model.getAllProcesses (/tracing/model/model.html:276:44)
at findChromeGpuProcess (/tracing/model/helpers/chrome_model_helper.html:32:30)
at ChromeModelHelper (/tracing/model/helpers/chrome_model_helper.html:48:22)
at Model.getOrCreateHelper (/tracing/model/model.html:142:60)
at ChromeAuditor (/tracing/extras/chrome/chrome_auditor.html:35:34)
at auditors.importOptions_.auditorConstructors.map.auditorConstructor (/tracing/importer/import.html:234:35)
at Array.map (native)
at addImportStage (/tracing/importer/import.html:233:60)

This error most often occurs with smpte_3840x2160_60fps_vp9.webm, but has been
observed on other media pages as well. It looks like the code only expects a
single thread named CrGpuMain, but in reality Chrome on Android sometimes has
multiple threads with that name.
 
John, when this happens next time, could you save one of the problematic traces and attach it to this bug?
Cc: johnchen@chromium.org liber...@chromium.org
Owner: charliea@chromium.org
Status: Assigned (was: Untriaged)
I'll get this fixed.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d2815a109a6c3a6607d8f6a5bd61071d8ff60c1

commit 9d2815a109a6c3a6607d8f6a5bd61071d8ff60c1
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Mar 31 00:57:49 2017

Roll src/third_party/catapult/ 94d1bb9f4..b13bd4732 (6 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/94d1bb9f4ab0..b13bd47327cb

$ git log 94d1bb9f4..b13bd4732 --date=short --no-merges --format='%ad %ae %s'
2017-03-30 sullivan Five bug fixes for generating benchmark health reports:
2017-03-30 charliea Changes ChromeGpuHelper.isGpuProcess to always return a boolean
2017-03-30 maxlg [Tracing] move functions from chrome_renderer_helper into loading_metric
2017-03-30 benjhayden Roll d8 on mac to 5.9.0.0.
2017-03-30 charliea Creates unit tests for ChromeGpuHelper's current behavior
2017-03-30 rnephew [Systrace] Fix systrace clock syncing issue with BattOr.

Created with:
  roll-dep src/third_party/catapult
BUG= 705847 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2788603003
Cr-Commit-Position: refs/heads/master@{#460964}

[modify] https://crrev.com/9d2815a109a6c3a6607d8f6a5bd61071d8ff60c1/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffdab5e343837739ef53675033fe9b38533263a3

commit ffdab5e343837739ef53675033fe9b38533263a3
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Mar 31 21:51:40 2017

Roll src/third_party/catapult/ 61fa8cdf5..7b2213093 (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/61fa8cdf5a0b..7b2213093441

$ git log 61fa8cdf5..7b2213093 --date=short --no-merges --format='%ad %ae %s'
2017-03-31 charliea Allows ChromeGpuHelper to recognize processes with multiple main threads

Created with:
  roll-dep src/third_party/catapult
BUG= 705847 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2791623003
Cr-Commit-Position: refs/heads/master@{#461238}

[modify] https://crrev.com/ffdab5e343837739ef53675033fe9b38533263a3/DEPS

Status: Fixed (was: Assigned)
This should be fixed on Chrome ToT. If you're still seeing problems, please reopen this bug and let me know.

Sign in to add a comment