New issue
Advanced search Search tips

Issue 705845 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Warning popup of input element with 'required' attribute in new options dialog of extension is not shown

Reported by klesto...@gmail.com, Mar 28 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.110 Safari/537.36

Steps to reproduce the problem:
1. open options.html in Chrome
2. press Enter or click OK
3. popup with message "Please fill out this field" will be shown
4. install extension
5. go to its Options
6. press Enter or click OK
7. no popup will be shown

What is the expected behavior?
popup with message "Please fill out this field" should be shown

What went wrong?
popup is not shown

Did this work before? No 

Does this work in other browsers? N/A

Chrome version: 57.0.2987.110  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 25.0 r0

Popup is shown if we add
"options_ui": {
  "open_in_tab": true
}
in manifest, or if we use old way to declare options:
"options_page": "options.html"

If nothing is entered in input, :invalid CSS selector is applied(background color is changed) and onsubmit event is not fired when OK is clicked or Enter is pressed. So Chrome takes notice of 'required' attribute, but doesn't show warning popup, when options dialog is displayed using new way.

Bug is not fixed for more then a year:
https://bugs.chromium.org/p/chromium/issues/detail?id=598204
 
required attr test.zip
889 bytes Download
Cc: jmukthavaram@chromium.org kalman@chromium.org
Components: Platform>Extensions
Labels: -Type-Bug -Pri-2 hasbisect M-59 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: roc...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on windows 7, Mac 10.12.4,Linux Ubuntu 14.04 with Chrome stable version-57.0.2987.133 and Canary-59.0.3061.0.
Manual Bisect:
Good-40.0.2205.0 -Revision-302055
Bad—40.0.2206.0 -Revision-302246

Bisect Tool Info:
You are probably looking for a change made after 302195 (known good), but no later than 302202 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/7df471a6892305f56a3b441eccff1be0145a067c..e6e040a21c78c9097600312d761c0295fa9312f1

Possible suspect from the above CL:
https://chromium.googlesource.com/chromium/src/+/496b34d93dbf9968d273e1d52f0ebb6f680a4f0c

Review URL: https://codereview.chromium.org/670623004
As 'kalman' email is getting bounced assigning to respective reviewer (Rockot).
Rockot@ Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.
Thanks.!

Comment 2 by roc...@chromium.org, Apr 10 2017

Cc: -kalman@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)

Sign in to add a comment