FATAL:GestureManager.cpp(121)] Check failed: false. |
|||||||||
Issue descriptionDebug Chrome crashes on Chrome OS OOBE (samus): [1:1:0327/203344.282250:FATAL:GestureManager.cpp(121)] Check failed: false. #0 0x627e44d45fed base::debug::StackTrace::StackTrace() #1 0x627e44d44cbc base::debug::StackTrace::StackTrace() #2 0x627e44d929cf logging::LogMessage::~LogMessage() #3 0x627e4cb27e34 blink::GestureManager::handleGestureEventInFrame() #4 0x627e4cb1fe5f blink::EventHandler::handleGestureEventInFrame() #5 0x627e4cb1f70c blink::EventHandler::handleGestureEvent() #6 0x627e4cb1ec0a blink::EventHandler::handleGestureEvent() #7 0x627e4bbaa907 blink::WebPagePopupImpl::handleGestureEvent() #8 0x627e4bb63b2f blink::PageWidgetDelegate::handleInputEvent() #9 0x627e4bbaac7d blink::WebPagePopupImpl::handleInputEvent() #10 0x627e4e56e431 content::RenderWidgetInputHandler::HandleInputEvent() #11 0x627e4e2420c1 content::RenderWidget::OnHandleInputEvent() #12 0x627e4e237f5b _ZN4base20DispatchToMethodImplIPN7content14RenderViewImplEMS2_FvPKN5blink13WebInputEventERKNSt7__debug6vectorIS7_SaIS7_EEERKN2ui11LatencyInfoENS1_22InputEventDispatchTypeEERKSt5tupleIJS7_SB_SF_SI_EEJLm0ELm1ELm2ELm3EEEEvRKT_T0_OT1_NS_13IndexSequenceIJ #13 0x627e4e255d20 _ZN4base16DispatchToMethodIPN7content12RenderWidgetEMS2_FvPKN5blink13WebInputEventERKNSt7__debug6vectorIS7_SaIS7_EEERKN2ui11LatencyInfoENS1_22InputEventDispatchTypeEERKSt5tupleIJS7_SB_SF_SI_EEEEvRKT_T0_OT1_ #14 0x627e4e255c89 _ZN3IPC16DispatchToMethodIN7content12RenderWidgetEMS2_FvPKN5blink13WebInputEventERKNSt7__debug6vectorIS6_SaIS6_EEERKN2ui11LatencyInfoENS1_22InputEventDispatchTypeEEvSt5tupleIJS6_SA_SE_SH_EEEEvPT_T0_PT1_RKT2_ #15 0x627e4e24d6d0 _ZN3IPC8MessageTI30InputMsg_HandleInputEvent_MetaSt5tupleIJPKN5blink13WebInputEventENSt7__debug6vectorIS6_SaIS6_EEEN2ui11LatencyInfoEN7content22InputEventDispatchTypeEEEvE8DispatchINSD_12RenderWidgetESI_vMSI_FvS6_RKSA_RKSC_SE_EEEbPKNS_7MessageEPT_PT0 #16 0x627e4e240542 content::RenderWidget::OnMessageReceived() #17 0x627e4f5dfa8b IPC::MessageRouter::RouteMessage() #18 0x627e4b6fe968 content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage() #19 0x627e4f5dfa0e IPC::MessageRouter::OnMessageReceived() #20 0x627e4b702def content::ChildThreadImpl::OnMessageReceived() #21 0x627e4e2151c1 _ZN4base8internal13FunctorTraitsIMN7content15ChildThreadImplEFbRKN3IPC7MessageEEvE6InvokeIPNS2_16RenderThreadImplEJS7_EEEbS9_OT_DpOT0_ #22 0x627e4e215116 _ZN4base8internal13FunctorTraitsINS0_18IgnoreResultHelperIMN7content15ChildThreadImplEFbRKN3IPC7MessageEEEEvE6InvokeIRKSB_JPNS3_16RenderThreadImplES8_EEEvOT_DpOT0_ #23 0x627e4e2150a7 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKNS0_18IgnoreResultHelperIMN7content15ChildThreadImplEFbRKN3IPC7MessageEEEEJPNS5_16RenderThreadImplESA_EEEvOT_DpOT0_ #24 0x627e4e215034 _ZN4base8internal7InvokerINS0_9BindStateINS0_18IgnoreResultHelperIMN7content15ChildThreadImplEFbRKN3IPC7MessageEEEEJNS0_17UnretainedWrapperINS4_16RenderThreadImplEEEEEEFvS9_EE7RunImplIRKSC_RKSt5tupleIJSF_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EE #25 0x627e4e214f5c _ZN4base8internal7InvokerINS0_9BindStateINS0_18IgnoreResultHelperIMN7content15ChildThreadImplEFbRKN3IPC7MessageEEEEJNS0_17UnretainedWrapperINS4_16RenderThreadImplEEEEEEFvS9_EE3RunEPNS0_13BindStateBaseES9_ #26 0x627e3f1041b2 _ZNKR4base8CallbackIFvRKNS0_IFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EEEELS3_1ELS4_1EE3RunES7_ #27 0x627e48754031 base::CancelableCallback<>::Forward() #28 0x627e3f163aaf _ZN4base8internal13FunctorTraitsIMN11google_apis13RequestSenderEFvRKNS_7WeakPtrINS2_29AuthenticatedRequestInterfaceEEEEvE6InvokeIRKNS4_IS3_EEJS8_EEEvSA_OT_DpOT0_ #29 0x627e4e214b1f _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMNS_18CancelableCallbackIFvRKN3IPC7MessageEEEEKFvS8_ERKNS_7WeakPtrISA_EEJS8_EEEvOT_OT0_DpOT1_ #30 0x627e4e214a97 _ZN4base8internal7InvokerINS0_9BindStateIMNS_18CancelableCallbackIFvRKN3IPC7MessageEEEEKFvS7_EJNS_7WeakPtrIS9_EEEEES8_E7RunImplIRKSB_RKSt5tupleIJSD_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEES7_ #31 0x627e4e2149cc _ZN4base8internal7InvokerINS0_9BindStateIMNS_18CancelableCallbackIFvRKN3IPC7MessageEEEEKFvS7_EJNS_7WeakPtrIS9_EEEEES8_E3RunEPNS0_13BindStateBaseES7_ #32 0x627e3f1041b2 _ZNKR4base8CallbackIFvRKNS0_IFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EEEELS3_1ELS4_1EE3RunES7_ #33 0x627e4e558bde content::InputEventFilter::HandleEventOnMainThread() #34 0x627e4e56932c content::MainThreadEventQueue::DispatchInFlightEvent() #35 0x627e4e5696da content::MainThreadEventQueue::DispatchSingleEvent() #36 0x627e4e56c257 _ZN4base8internal13FunctorTraitsIMN7content20MainThreadEventQueueEFvvEvE6InvokeIRK13scoped_refptrIS3_EJEEEvS5_OT_DpOT0_ #37 0x627e4e56c1a1 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN7content20MainThreadEventQueueEFvvEJRK13scoped_refptrIS5_EEEEvOT_DpOT0_ #38 0x627e4e56c142 _ZN4base8internal7InvokerINS0_9BindStateIMN7content20MainThreadEventQueueEFvvEJ13scoped_refptrIS4_EEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #39 0x627e4e56c08c _ZN4base8internal7InvokerINS0_9BindStateIMN7content20MainThreadEventQueueEFvvEJ13scoped_refptrIS4_EEEEFvvEE3RunEPNS0_13BindStateBaseE #40 0x627e3f850829 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv #41 0x627e44fa0c22 base::debug::TaskAnnotator::RunTask() #42 0x627e4ba19256 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() #43 0x627e4ba161fd blink::scheduler::TaskQueueManager::DoWork() #44 0x627e3f6c6ed4 _ZN4base8internal13FunctorTraitsIMN2ui21DrmThreadMessageProxyEKFvbEvE6InvokeIRKNS_7WeakPtrIS3_EEJbEEEvS5_OT_DpOT0_ #45 0x627e4ba20b3f _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5blink9scheduler16TaskQueueManagerEFvbERKNS_7WeakPtrIS6_EEJRKbEEEvOT_OT0_DpOT1_ #46 0x627e4ba20ab3 _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE7RunImplIRKS7_RKSt5tupleIJS9_bEEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #47 0x627e4ba209cc _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE3RunEPNS0_13BindStateBaseE #48 0x627e3f850829 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv #49 0x627e44fa0c22 base::debug::TaskAnnotator::RunTask() #50 0x627e44db53bd base::MessageLoop::RunTask() #51 0x627e44db5664 base::MessageLoop::DeferOrRunPendingTask() #52 0x627e44db5990 base::MessageLoop::DoWork() #53 0x627e44dd04b8 base::MessagePumpDefault::Run() #54 0x627e44db4f17 base::MessageLoop::RunHandler() #55 0x627e44e5705a base::RunLoop::Run() #56 0x627e4e27a126 content::RendererMain() #57 0x627e43e78f9e content::RunZygote() #58 0x627e43e79390 content::RunNamedProcessTypeMain() #59 0x627e43e7b5fc content::ContentMainRunnerImpl::Run() #60 0x627e43e7876a content::ContentServiceManagerMainDelegate::Run() #61 0x627e47cd9548 service_manager::Main()
,
Mar 28 2017
Can you tell us what SHA you were building against? Line 121 is a brace in ToT.
,
Mar 28 2017
tdresser@ neither of these event types are handled in the code path:
GestureFlingCancel,
GestureDoubleTap,
And I believe it is hitting the not-reached due to that.
I don't believe it is GestureFlingCancel because it would have failed here:
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebGestureEvent.h?dr&q=isScrollEvent&l=201
Which I think we should fix.
So it must be gesture double tap and I think we can likely just return false in this code and avoid the not-reached.
,
Mar 28 2017
,
Mar 28 2017
Sounds reasonable to me. Sahel, could you take a look at this?
,
Mar 28 2017
Sure, I will investigate it.
,
Mar 28 2017
I fixed it in change: https://codereview.chromium.org/2780803002/ It is waiting on review from rbyers.
,
Mar 28 2017
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65d6e34d665cd4ad6c23066d1500e0fa8eae2070 commit 65d6e34d665cd4ad6c23066d1500e0fa8eae2070 Author: dtapuska <dtapuska@chromium.org> Date: Wed Mar 29 13:37:23 2017 Fix dcheck failing on ChromeOS Fix some code paths that should be handling the GestureFlingCancel event. Treat GestureFlingCancel as a scroll event. BUG= 705817 , 705810 , 705828 Review-Url: https://codereview.chromium.org/2780803002 Cr-Commit-Position: refs/heads/master@{#460371} [modify] https://crrev.com/65d6e34d665cd4ad6c23066d1500e0fa8eae2070/third_party/WebKit/Source/core/input/ScrollManager.cpp [modify] https://crrev.com/65d6e34d665cd4ad6c23066d1500e0fa8eae2070/third_party/WebKit/public/platform/WebGestureEvent.h
,
Mar 29 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by alemate@chromium.org
, Mar 28 2017