-wasHidden isn't called in tab.mm when using toolbar side swipe |
|||||||||
Issue description- Open two tabs - Toolbar side swipe between them - wasHidden isn't called on deactivated tab. Unclear if this was always broken, or a tab refactor broke it.
,
Mar 31 2017
,
Apr 3 2017
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71e3604b522136b8fe4226941b67b72f56c7d921 commit 71e3604b522136b8fe4226941b67b72f56c7d921 Author: pinkerton <pinkerton@chromium.org> Date: Mon Apr 03 14:27:55 2017 Fix tab deselect notifications. Fix the post notification for tab deselection to send from the proper object and include the userInfo. BUG= 705826 TEST=no visible changes. Review-Url: https://codereview.chromium.org/2788233002 Cr-Commit-Position: refs/heads/master@{#461426} [modify] https://crrev.com/71e3604b522136b8fe4226941b67b72f56c7d921/ios/chrome/browser/tabs/tab_model_selected_tab_observer.mm
,
Apr 3 2017
,
Apr 3 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.
,
Apr 3 2017
Rohit: does this need to go onto the m58 branch? Can you cherrypick?
,
Apr 4 2017
,
Apr 4 2017
This bug requires manual review: Less than 17 days to go before AppStore submit on M58 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 4 2017
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a0218a9df0639f60d99fad06554acb2ff8176d4 commit 1a0218a9df0639f60d99fad06554acb2ff8176d4 Author: Justin Cohen <justincohen@google.com> Date: Tue Apr 04 19:29:31 2017 Fix tab deselect notifications. Fix the post notification for tab deselection to send from the proper object and include the userInfo. BUG= 705826 TEST=no visible changes. Review-Url: https://codereview.chromium.org/2788233002 Cr-Commit-Position: refs/heads/master@{#461426} (cherry picked from commit 71e3604b522136b8fe4226941b67b72f56c7d921) Review-Url: https://codereview.chromium.org/2797823002 . Cr-Commit-Position: refs/branch-heads/3029@{#576} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/1a0218a9df0639f60d99fad06554acb2ff8176d4/ios/chrome/browser/tabs/tab_model_selected_tab_observer.mm |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by pinkerton@chromium.org
, Mar 28 2017Components: UI>Browser>Core
Labels: OS-iOS
Owner: pinkerton@chromium.org
Status: Assigned (was: Untriaged)