Add support for Performance Observer in Worker. Currently Worker supports old Performance Timeline, but not Performance Timeline 2 (Observer).
Based on the discussion earlier, it sounds like it's already implemented but not enabled? If so, what's stopping us from enabling it?
It was explicitly coded to be not be supported in worker (only Window) in the custom V8 binding in the CL adding PerformanceObserver initially: https://codereview.chromium.org/1198863006/diff/400001/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp I'd have to look into updating the bindings. mpb@ any context on why - other than limiting the scope of the CL initially?
*bump* I don't remember any particular reason, guessing this was an oversight. Shubhie, can we enable this in one of the upcoming releases?
If we could find an appropriate mentor, would this be a reasonable first bug?
Yes.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca205ddf1a960d002da75bbcdd8243757a77e817 commit ca205ddf1a960d002da75bbcdd8243757a77e817 Author: npm <npm@chromium.org> Date: Fri Jul 07 17:43:34 2017 Add LayoutTest for PerformanceObserver inside Worker BUG= chromium:705820 Review-Url: https://codereview.chromium.org/2953993003 Cr-Commit-Position: refs/heads/master@{#484973} [add] https://crrev.com/ca205ddf1a960d002da75bbcdd8243757a77e817/third_party/WebKit/LayoutTests/external/wpt/performance-timeline/resources/worker-with-performance-observer.js [add] https://crrev.com/ca205ddf1a960d002da75bbcdd8243757a77e817/third_party/WebKit/LayoutTests/external/wpt/performance-timeline/worker-with-performance-observer-expected.txt [add] https://crrev.com/ca205ddf1a960d002da75bbcdd8243757a77e817/third_party/WebKit/LayoutTests/external/wpt/performance-timeline/worker-with-performance-observer.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd47b272d20f2604283d2c23ab20db589429a802 commit bd47b272d20f2604283d2c23ab20db589429a802 Author: Nicolas Pena <npm@chromium.org> Date: Fri Aug 04 22:35:33 2017 Allow PerformanceObserver within Worker This CL exposes PerformanceObserver to Worker and fixes tests accordingly. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/vpPUStxToGY Bug: chromium:705820 , chromium:747457 Change-Id: I2e174e5aff57617b7af86f0f896603e05c85f35d Reviewed-on: https://chromium-review.googlesource.com/577957 Commit-Queue: Nicolás Peña <npm@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Shubhie Panicker <panicker@chromium.org> Cr-Commit-Position: refs/heads/master@{#492153} [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/7923722cfe87a3f6b459b668c1a901d96080a681/third_party/WebKit/LayoutTests/external/wpt/performance-timeline/worker-with-performance-observer-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/Source/core/timing/PerformanceBase.cpp [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/Source/core/timing/PerformanceEntry.idl [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp [modify] https://crrev.com/bd47b272d20f2604283d2c23ab20db589429a802/third_party/WebKit/Source/core/timing/PerformanceObserver.idl
Comment 1 by igrigo...@chromium.org
, Mar 28 2017