Issue 705753 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ chili@chromium.org Last visit 22 days ago
Closed:	Mar 2017
Components:	UI>Browser>Offline
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug

Background Loader should use snapshot controller

Project Member Reported by chili@chromium.org, Mar 27 2017

Issue description

It currently uses a timer with some weak ptr invalidation. It should ideally use snapshot controller so we have consistency.

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e101d81bbdb680bd24286fab8d799c5116257744

commit e101d81bbdb680bd24286fab8d799c5116257744
Author: chili <chili@chromium.org>
Date: Tue Mar 28 01:24:23 2017

[Offline pages] Integrate snapshot controller fully into background loader.

BUG= 705753 

Review-Url: https://codereview.chromium.org/2769043002
Cr-Commit-Position: refs/heads/master@{#459967}

[modify] https://crrev.com/e101d81bbdb680bd24286fab8d799c5116257744/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/e101d81bbdb680bd24286fab8d799c5116257744/chrome/browser/android/offline_pages/background_loader_offliner.h

Comment 2 by chili@chromium.org, Mar 28 2017

Status: Fixed (was: Started)

►

Issue 705753 link

Issue metadata

Background Loader should use snapshot controller

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 28 2017

Comment 1 Deleted

Comment 2 by chili@chromium.org, Mar 28 2017

Comment 2 Deleted

Sign in to add a comment