New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705741 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 754889



Sign in to add a comment

Add global UKM source ids

Project Member Reported by holte@chromium.org, Mar 27 2017

Issue description

We want to have globally scoped UKM Source ids so that we can record the URL information in one place instead of having each metric provider record it.

Something like NavigationHandle::GlobalRequestID would be a good fit, but it currently defined in all cases.
 

Comment 1 by holte@chromium.org, Mar 27 2017

Owner: oysteine@chromium.org
Status: Started (was: Untriaged)
Oystein, have you already started this?
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef24a291c6ecdac0f3fc509304e3a128268bfcba

commit ef24a291c6ecdac0f3fc509304e3a128268bfcba
Author: Steven Holte <holte@google.com>
Date: Fri Aug 04 23:59:08 2017

Add unique NavigationIDs to NavigationHandles.

This allows UKM logs to have a unambiguous way of referring to a
particular navigation.

PageLoadTracker is modified to start using them.

Bug:  705741 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ib1c57d3d37cba55b207912480b9a0f44f3846074
Reviewed-on: https://chromium-review.googlesource.com/580586
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492185}
[modify] https://crrev.com/ef24a291c6ecdac0f3fc509304e3a128268bfcba/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/ef24a291c6ecdac0f3fc509304e3a128268bfcba/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/ef24a291c6ecdac0f3fc509304e3a128268bfcba/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/ef24a291c6ecdac0f3fc509304e3a128268bfcba/content/public/browser/navigation_handle.h

Comment 3 by holte@chromium.org, Aug 11 2017

Blockedon: 754889

Comment 4 by holte@chromium.org, Sep 1 2017

Components: Internals>Metrics>UKM
Owner: holte@chromium.org
Steve, is there anything else to be done here or can this be closed?

Comment 6 by holte@chromium.org, Mar 2 2018

Status: Fixed (was: Started)
I think all of the work here is complete since we have Navigation IDs on all platforms.

Sign in to add a comment