Add a way to have a window indicate that it should autohide the shelf when it is the active window. This is the Chrome side bug for b/35874703.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23552624dd10da3c8add0d1e1ef3577898713a8c commit 23552624dd10da3c8add0d1e1ef3577898713a8c Author: yorkelee <yorkelee@google.com> Date: Wed Mar 29 14:46:28 2017 Add set_autohide_systemui to wayland protocol * Bump multi-display wayland APIs to version 4. * Add set_autohide_systemui to version 3 of zcr_remote_shell_v1 BUG= 705723 TEST=Verify that making the autohide request from Android results in the trace being logged. Unit tests will be added together with the actual implementation in the next CL. Review-Url: https://codereview.chromium.org/2777373002 Cr-Commit-Position: refs/heads/master@{#460383} [modify] https://crrev.com/23552624dd10da3c8add0d1e1ef3577898713a8c/components/exo/shell_surface.cc [modify] https://crrev.com/23552624dd10da3c8add0d1e1ef3577898713a8c/components/exo/shell_surface.h [modify] https://crrev.com/23552624dd10da3c8add0d1e1ef3577898713a8c/components/exo/wayland/server.cc [modify] https://crrev.com/23552624dd10da3c8add0d1e1ef3577898713a8c/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h [modify] https://crrev.com/23552624dd10da3c8add0d1e1ef3577898713a8c/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h [modify] https://crrev.com/23552624dd10da3c8add0d1e1ef3577898713a8c/third_party/wayland-protocols/protocol/remote-shell-protocol.c [modify] https://crrev.com/23552624dd10da3c8add0d1e1ef3577898713a8c/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74669cbfbef72bde5abdecb18e9c7920cca51419 commit 74669cbfbef72bde5abdecb18e9c7920cca51419 Author: yorkelee <yorkelee@google.com> Date: Thu Mar 30 22:22:07 2017 Add ability to have active window autohide shelf * Actual implementation of ShellSurface.setSystemUiVisibility * Add hide_shelf_when_active_ flag to window_state which the ShelfLayoutManager uses to determine if the currently active window should autohide the shelf. * Update flag accordingly from ShellSurface BUG= 705723 TEST=New unit tests, and also verify that using the implementation from Android correctly autohides the shelf for the active Android window. Add set_systemui_visibility to wayland Review-Url: https://codereview.chromium.org/2782223002 Cr-Commit-Position: refs/heads/master@{#460907} [modify] https://crrev.com/74669cbfbef72bde5abdecb18e9c7920cca51419/ash/common/shelf/shelf_layout_manager.cc [modify] https://crrev.com/74669cbfbef72bde5abdecb18e9c7920cca51419/ash/common/shelf/shelf_layout_manager.h [modify] https://crrev.com/74669cbfbef72bde5abdecb18e9c7920cca51419/ash/common/wm/window_state.cc [modify] https://crrev.com/74669cbfbef72bde5abdecb18e9c7920cca51419/ash/common/wm/window_state.h [modify] https://crrev.com/74669cbfbef72bde5abdecb18e9c7920cca51419/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/74669cbfbef72bde5abdecb18e9c7920cca51419/ash/wm/window_util.cc [modify] https://crrev.com/74669cbfbef72bde5abdecb18e9c7920cca51419/ash/wm/window_util.h [modify] https://crrev.com/74669cbfbef72bde5abdecb18e9c7920cca51419/components/exo/shell_surface.cc [modify] https://crrev.com/74669cbfbef72bde5abdecb18e9c7920cca51419/components/exo/shell_surface_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c28587f7bf7b2bf859d8514879b504f46660fa8 commit 7c28587f7bf7b2bf859d8514879b504f46660fa8 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Mar 31 11:37:47 2017 Add set_autohide_systemui to wayland protocol * Bump multi-display wayland APIs to version 4. * Add set_autohide_systemui to version 3 of zcr_remote_shell_v1 BUG= 705723 TEST=Verify that making the autohide request from Android results in the trace being logged. Unit tests will be added together with the actual implementation in the next CL. Review-Url: https://codereview.chromium.org/2777373002 Cr-Commit-Position: refs/heads/master@{#460383} (cherry picked from commit 23552624dd10da3c8add0d1e1ef3577898713a8c) Review-Url: https://codereview.chromium.org/2785283003 . Cr-Commit-Position: refs/branch-heads/3029@{#511} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/7c28587f7bf7b2bf859d8514879b504f46660fa8/components/exo/shell_surface.cc [modify] https://crrev.com/7c28587f7bf7b2bf859d8514879b504f46660fa8/components/exo/shell_surface.h [modify] https://crrev.com/7c28587f7bf7b2bf859d8514879b504f46660fa8/components/exo/wayland/server.cc [modify] https://crrev.com/7c28587f7bf7b2bf859d8514879b504f46660fa8/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h [modify] https://crrev.com/7c28587f7bf7b2bf859d8514879b504f46660fa8/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h [modify] https://crrev.com/7c28587f7bf7b2bf859d8514879b504f46660fa8/third_party/wayland-protocols/protocol/remote-shell-protocol.c [modify] https://crrev.com/7c28587f7bf7b2bf859d8514879b504f46660fa8/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52 commit d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Mar 31 21:52:55 2017 Add ability to have active window autohide shelf * Actual implementation of ShellSurface.setSystemUiVisibility * Add hide_shelf_when_active_ flag to window_state which the ShelfLayoutManager uses to determine if the currently active window should autohide the shelf. * Update flag accordingly from ShellSurface BUG= 705723 TEST=New unit tests, and also verify that using the implementation from Android correctly autohides the shelf for the active Android window. Add set_systemui_visibility to wayland Review-Url: https://codereview.chromium.org/2782223002 Cr-Commit-Position: refs/heads/master@{#460907} (cherry picked from commit 74669cbfbef72bde5abdecb18e9c7920cca51419) Review-Url: https://codereview.chromium.org/2790943003 . Cr-Commit-Position: refs/branch-heads/3029@{#520} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52/ash/common/shelf/shelf_layout_manager.cc [modify] https://crrev.com/d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52/ash/common/shelf/shelf_layout_manager.h [modify] https://crrev.com/d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52/ash/common/wm/window_state.cc [modify] https://crrev.com/d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52/ash/common/wm/window_state.h [modify] https://crrev.com/d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52/ash/wm/window_util.cc [modify] https://crrev.com/d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52/ash/wm/window_util.h [modify] https://crrev.com/d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52/components/exo/shell_surface.cc [modify] https://crrev.com/d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52/components/exo/shell_surface_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Mar 29 2017