New issue
Advanced search Search tips

Issue 705722 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

clang-format doesn't add space between () and {} in virtual empty method.

Project Member Reported by dmu...@chromium.org, Mar 27 2017

Issue description

When you have a virtual class with a method like so:

class LevelDBIterator {
 public:
  virtual ~LevelDBIterator() {}
  virtual bool IsValid() const = 0;
  virtual leveldb::Status SeekToLast() = 0;
  virtual leveldb::Status Seek(const base::StringPiece& target) = 0;
  virtual leveldb::Status Next() = 0;
  virtual leveldb::Status Prev() = 0;
  virtual base::StringPiece Key() const = 0;
  virtual base::StringPiece Value() const = 0;
  // #### HERE:
  virtual void Detach() {};
};


clang-format will remove the space between () and {} for the "Detach" method. I think this is wrong.
 

Comment 1 by dmu...@chromium.org, Apr 14 2017

Components: Tools

Sign in to add a comment