New issue
Advanced search Search tips

Issue 705716 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 709593

Blocking:
issue 731255



Sign in to add a comment

Add --run-in-mus switch to run browser_tests in mushrome mode

Project Member Reported by sky@chromium.org, Mar 27 2017

Issue description

We'll need this in addition to --run-in-mash.

Jon, as you've done a bunch with browser_tests I'm passing this your way. If you have had enough of tests kick it back my way.
 
Blockedon: 709593
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3fba3aea86a7aa5292cdd01bc133cd98a363135

commit e3fba3aea86a7aa5292cdd01bc133cd98a363135
Author: jonross <jonross@chromium.org>
Date: Fri Apr 21 15:06:25 2017

Mus Browser Tests

This change modifies MashBrowserTestsMain and MojoTestConnector in order to
support also running with the flag "--run-in-mus".

Additionally the build configuration for mus_browser_tests_catalog lists a
smaller subset of supported services than mash_browser_tests_catalog. To align
with differences between --mash and --mus

This change does not include any enabling on trybots. A subsequent change will
first enable on FYI bots, then later on directly on the main trybots.

TEST=mus_browser_tests, mash_browser_tests
BUG= 705716 

Review-Url: https://codereview.chromium.org/2834693002
Cr-Commit-Position: refs/heads/master@{#466338}

[modify] https://crrev.com/e3fba3aea86a7aa5292cdd01bc133cd98a363135/chrome/test/BUILD.gn
[modify] https://crrev.com/e3fba3aea86a7aa5292cdd01bc133cd98a363135/chrome/test/base/mash_browser_tests_main.cc
[modify] https://crrev.com/e3fba3aea86a7aa5292cdd01bc133cd98a363135/chrome/test/base/mojo_test_connector.cc
[modify] https://crrev.com/e3fba3aea86a7aa5292cdd01bc133cd98a363135/chrome/test/base/mojo_test_connector.h
[add] https://crrev.com/e3fba3aea86a7aa5292cdd01bc133cd98a363135/chrome/test/base/mus_browser_tests_manifest.json
[add] https://crrev.com/e3fba3aea86a7aa5292cdd01bc133cd98a363135/testing/buildbot/filters/mus.browser_tests.filter

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a0288a5e8d47ab32160cdabd48c7c8faf871060

commit 6a0288a5e8d47ab32160cdabd48c7c8faf871060
Author: jonross <jonross@chromium.org>
Date: Mon Apr 24 16:33:27 2017

Enable mus_browser_tests on trybot

This adds mus_browser_tests to the linux_chromium_chromeos_ozone_rel_ng trybot.
The list of enabled tests is based on the results from the Mojo FYI bots running
the test suite. There were no flakes over the weekend.

TEST=mus_browser_tests
BUG= 705716 

Review-Url: https://codereview.chromium.org/2835163002
Cr-Commit-Position: refs/heads/master@{#466652}

[modify] https://crrev.com/6a0288a5e8d47ab32160cdabd48c7c8faf871060/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/6a0288a5e8d47ab32160cdabd48c7c8faf871060/testing/buildbot/filters/BUILD.gn
[modify] https://crrev.com/6a0288a5e8d47ab32160cdabd48c7c8faf871060/testing/buildbot/filters/mus.browser_tests.filter

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfc77e6d1679d209b140a396f131b47ef7d29ab1

commit dfc77e6d1679d209b140a396f131b47ef7d29ab1
Author: jonross <jonross@chromium.org>
Date: Thu Apr 27 02:26:26 2017

Expand mus_browser_tests on Mojo FYI bots

Update the filter for mus_browser_tests used on Mojo FYI bots with more tests
that pass locally.

TBR=sky@chromium.org
TEST=mus_browser_tests
BUG= 705716 

Review-Url: https://codereview.chromium.org/2844853002
Cr-Commit-Position: refs/heads/master@{#467552}

[modify] https://crrev.com/dfc77e6d1679d209b140a396f131b47ef7d29ab1/testing/buildbot/filters/mojo.fyi.mus.browser_tests.filter

Project Member

Comment 5 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7c0e7db6402fdb3ca65b7e6ffa44989ee056c13

commit f7c0e7db6402fdb3ca65b7e6ffa44989ee056c13
Author: jonross <jonross@chromium.org>
Date: Wed May 03 19:00:37 2017

Disable Failing Mus Browser Tests

A bunch of mus_browser_tests are failing. I'm disabling these to unblock the CQ
until we can find the cause.

I'm leaving one test that is passing in order to still have coverage of the mus
envionrment.

TBR=sky@chromium.org
TEST=mus_browser_tests
BUG= 705716 

Review-Url: https://codereview.chromium.org/2857943003
Cr-Commit-Position: refs/heads/master@{#469060}

[modify] https://crrev.com/f7c0e7db6402fdb3ca65b7e6ffa44989ee056c13/testing/buildbot/filters/mus.browser_tests.filter

Project Member

Comment 6 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82b28ae6b86cc9d0a8bcbb706fcbaeb3544e5b4e

commit 82b28ae6b86cc9d0a8bcbb706fcbaeb3544e5b4e
Author: jonross <jonross@chromium.org>
Date: Thu May 25 16:02:03 2017

Re-enable mus_browser_tests

Some mus_browser_tests had been timing out. The source of those failures should
be fixed now. Reenabling them on the CQ, as they've been passing on the Mojo FYI bot.

TBR=sky@chromium.org
TEST=mus_browser_tests
BUG= 705716 

Review-Url: https://codereview.chromium.org/2899353002
Cr-Commit-Position: refs/heads/master@{#474664}

[modify] https://crrev.com/82b28ae6b86cc9d0a8bcbb706fcbaeb3544e5b4e/testing/buildbot/filters/mus.browser_tests.filter

Comment 7 by sky@chromium.org, Jun 8 2017

Blocking: 731255
Status: Fixed (was: Assigned)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment