New issue
Advanced search Search tips

Issue 705715 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

add ash_mus_unittests

Project Member Reported by sky@chromium.org, Mar 27 2017

Issue description

This should be ash_unittests running in mushrome mode.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25b49b2809f59ba95b9abc95ac0a0adaf4c97722

commit 25b49b2809f59ba95b9abc95ac0a0adaf4c97722
Author: sky <sky@chromium.org>
Date: Fri Mar 31 14:41:13 2017

Adds ability for ash_unittests to run in mushrome mode

This makes it so that if you supply --mus to ash*unittests it'll run
in mushrome mode. A slew of tests fail with --mus, but this at least
enables mushrome mode for tests.

BUG= 705715 
TEST=test only changes
R=msw@chromium.org, reveman@chromium.org

Review-Url: https://codereview.chromium.org/2788463003
Cr-Commit-Position: refs/heads/master@{#461119}

[modify] https://crrev.com/25b49b2809f59ba95b9abc95ac0a0adaf4c97722/ash/BUILD.gn
[modify] https://crrev.com/25b49b2809f59ba95b9abc95ac0a0adaf4c97722/ash/test/ash_test_base.cc
[modify] https://crrev.com/25b49b2809f59ba95b9abc95ac0a0adaf4c97722/ash/test/ash_test_helper.cc
[modify] https://crrev.com/25b49b2809f59ba95b9abc95ac0a0adaf4c97722/ash/test/ash_test_helper.h
[modify] https://crrev.com/25b49b2809f59ba95b9abc95ac0a0adaf4c97722/ash/test/ash_test_suite.cc
[modify] https://crrev.com/25b49b2809f59ba95b9abc95ac0a0adaf4c97722/ash/test/ash_test_suite.h
[modify] https://crrev.com/25b49b2809f59ba95b9abc95ac0a0adaf4c97722/components/exo/BUILD.gn
[modify] https://crrev.com/25b49b2809f59ba95b9abc95ac0a0adaf4c97722/mash/BUILD.gn
[modify] https://crrev.com/25b49b2809f59ba95b9abc95ac0a0adaf4c97722/mash/test/DEPS
[modify] https://crrev.com/25b49b2809f59ba95b9abc95ac0a0adaf4c97722/mash/test/mash_test_suite.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be0a78336df511783b675d9356631f8a6521f3e4

commit be0a78336df511783b675d9356631f8a6521f3e4
Author: sky <sky@chromium.org>
Date: Fri Mar 31 20:02:25 2017

Makes AshTestImpl::Create create the right impl based on config

Previously there was a factory function that was expected to be
compiled into the target for the creation. Now that AshTestHelper
knows the config the factory function can be shared. This is necessary
for ash_unittests so that it can work with and without --mus.

Also note that AshTestImpl should go away eventually.

BUG= 705715 
TEST=test only changes
R=msw@chromium.org, reveman@chromium.org

Review-Url: https://codereview.chromium.org/2790903002
Cr-Commit-Position: refs/heads/master@{#461195}

[modify] https://crrev.com/be0a78336df511783b675d9356631f8a6521f3e4/ash/BUILD.gn
[modify] https://crrev.com/be0a78336df511783b675d9356631f8a6521f3e4/ash/mus/test/ash_test_impl_mus.cc
[modify] https://crrev.com/be0a78336df511783b675d9356631f8a6521f3e4/ash/test/BUILD.gn
[modify] https://crrev.com/be0a78336df511783b675d9356631f8a6521f3e4/ash/test/ash_test_helper.h
[modify] https://crrev.com/be0a78336df511783b675d9356631f8a6521f3e4/ash/test/ash_test_impl_aura.cc
[modify] https://crrev.com/be0a78336df511783b675d9356631f8a6521f3e4/chrome/test/BUILD.gn
[modify] https://crrev.com/be0a78336df511783b675d9356631f8a6521f3e4/components/exo/BUILD.gn

Cc: jonr...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4

commit ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4
Author: sky <sky@chromium.org>
Date: Thu Apr 06 21:28:26 2017

Adds ash_mus_unittests to FYI bot

There are a slew of failures that need to be investigated. Rather than
early out all the tests I'm adding a filter file. This makes it easier
to retry tests as functionality is addded.

I've also cleaned up a handful of things in looking at failures.

BUG= 705715 
TEST=this is test change
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2803933003
Cr-Commit-Position: refs/heads/master@{#462628}

[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/ash/common/test/ash_test.h
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/ash/display/display_configuration_controller_unittest.cc
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/ash/display/mirror_window_controller_unittest.cc
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/ash/display/screen_ash_unittest.cc
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/ash/display/screen_position_controller_unittest.cc
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/testing/buildbot/chromium.fyi.json
[add] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/testing/buildbot/filters/ash_mus_unittests.filter
[modify] https://crrev.com/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d3963df0be6c3ba1fcf24789d40c85a58c7ea4f

commit 4d3963df0be6c3ba1fcf24789d40c85a58c7ea4f
Author: sky <sky@chromium.org>
Date: Mon Apr 10 19:23:11 2017

Adds executable for ash_mus_unittests builtbot test config

Without this the bots try to use ash_mus_unittests, which doesn't
exist.

BUG= 705715 
TEST=this is test change
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2802163004
Cr-Commit-Position: refs/heads/master@{#463357}

[modify] https://crrev.com/4d3963df0be6c3ba1fcf24789d40c85a58c7ea4f/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b03d40ddb1f2055726b64457ea5a41d29fb6223f

commit b03d40ddb1f2055726b64457ea5a41d29fb6223f
Author: sky <sky@chromium.org>
Date: Mon Apr 10 22:53:28 2017

Adds label_type: Group to gn_isolate_map.pyl

Hopefully this gets generating build files on mojo fyi bot working.

BUG= 705715 
TEST=this is test change
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2810733004
Cr-Commit-Position: refs/heads/master@{#463432}

[modify] https://crrev.com/b03d40ddb1f2055726b64457ea5a41d29fb6223f/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 11 2017

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcfbb28d15e624ef7e4efe48c3a3086d4777d03a

commit fcfbb28d15e624ef7e4efe48c3a3086d4777d03a
Author: sky <sky@chromium.org>
Date: Tue Apr 11 20:06:27 2017

Adds target for ash_mus_unittests filter file

Hopefully this makes it so the swarming targets get the filter file.

BUG= 705715 
TEST=this is test change
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2813923002
Cr-Commit-Position: refs/heads/master@{#463741}

[modify] https://crrev.com/fcfbb28d15e624ef7e4efe48c3a3086d4777d03a/ash/BUILD.gn
[modify] https://crrev.com/fcfbb28d15e624ef7e4efe48c3a3086d4777d03a/testing/buildbot/filters/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/729110102e87635cba60ede6f631d68a374d25e8

commit 729110102e87635cba60ede6f631d68a374d25e8
Author: sky <sky@chromium.org>
Date: Tue Apr 11 23:19:53 2017

Disables a couple more tests for ash_unittests --mus

These are failing on the bot. Will investigate separately.

BUG= 705715 , 622480 
TEST=this is test change
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2814563006
Cr-Commit-Position: refs/heads/master@{#463829}

[modify] https://crrev.com/729110102e87635cba60ede6f631d68a374d25e8/testing/buildbot/filters/ash_mus_unittests.filter

Comment 10 by sky@chromium.org, Apr 17 2017

Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbfea6ff41a33e73312113c90f055ce7ac35ba1d

commit dbfea6ff41a33e73312113c90f055ce7ac35ba1d
Author: sky <sky@chromium.org>
Date: Mon Apr 17 22:34:47 2017

Disables more tests for ash_unittests --mus

And disables creation of a couple of objects in ash that make use of a
class (DeviceDataManager) that is not created.

BUG= 712290 , 705715 
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2820103003
Cr-Commit-Position: refs/heads/master@{#465045}

[modify] https://crrev.com/dbfea6ff41a33e73312113c90f055ce7ac35ba1d/ash/shell.cc
[modify] https://crrev.com/dbfea6ff41a33e73312113c90f055ce7ac35ba1d/testing/buildbot/filters/ash_mus_unittests.filter

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a53f68744f93a8b322d5b73ed028491dcdd9612e

commit a53f68744f93a8b322d5b73ed028491dcdd9612e
Author: sky <sky@chromium.org>
Date: Tue Apr 18 19:30:41 2017

chromeos: Adds ash_mus_unittests to the main waterfall

The tests have been passing since yesterday.

BUG= 705715 
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2823273002
Cr-Commit-Position: refs/heads/master@{#465327}

[modify] https://crrev.com/a53f68744f93a8b322d5b73ed028491dcdd9612e/testing/buildbot/chromium.chromiumos.json

Comment 13 by sky@chromium.org, Apr 18 2017

Status: Fixed (was: Started)
This is now on the main waterfall, so closing. Will file bugs on disabled tests once simplified display management is working.

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment