New issue
Advanced search Search tips

Issue 705714 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 705831



Sign in to add a comment

Make ChromeLauncherControllerImpl a WmDisplayObserver

Project Member Reported by sky@chromium.org, Mar 27 2017

Issue description

I'm assuming we'll end up using ChromeLauncherControllerImpl in mushrome mode, which means WindowTreeHostManager::Observer won't work. Instead it should be convered to WmDisplayObserver.
 

Comment 1 by msw@chromium.org, Mar 28 2017

Blockedon: 705831
Perhaps this is blocked on  Issue 705831 ?

Comment 2 by sky@chromium.org, Mar 28 2017

WmDisplayObserver works for classic, so you could do the change now and not regress that. But you're right, in order for this to fully work 705831 needs to be fixed.

Comment 3 by msw@chromium.org, Sep 19 2017

Status: WontFix (was: Assigned)
I think this is moot; ChromeLauncherController is no longer a WindowTreeHostManager::Observer.
ShelfController is a WindowTreeHostManager::Observer, but that seems okay?
Please reopen if there is an action item here.

Sign in to add a comment