This should work fine for mushrome, but not mash. Removing as blocker from mushrome.

For searching: display_rotation_default_handler.cc

We can use cros_display_config.mojom for this now.

Steven, I would hold off on this unless you're mostly done with it. I'm working on a generic way to get CrosSettings to push data into ash. If we had that then I think DeviceRotationDefaultHandler could move into ash mostly as-is.

WIP CL https://chromium-review.googlesource.com/#/c/chromium/src/+/1042880

Sounds promising, I will hold off on this.

Based on discussion in issue 446937, moving enough of CrosSettings to Ash to support DisplayRotationDefaultHandler is going to be complicated.

Instead, it should be straightforward to migrate this class to use the cros_display_config mojo API.

This works fine in single-process mash, but not multi-process mash.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c882c7cb9570b839efc986f11115e830af79810c

commit c882c7cb9570b839efc986f11115e830af79810c
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 15 19:57:00 2018

chromeos: update bug id in chrome/browser/ui/ash/chrome_shell_delegate.cc

BUG= 705713 
TEST=none

Change-Id: Ic8679c208d015e5019684e581e520b343bf411e1
Reviewed-on: https://chromium-review.googlesource.com/1176107
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583366}
[modify] https://crrev.com/c882c7cb9570b839efc986f11115e830af79810c/chrome/browser/ui/ash/chrome_shell_delegate.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7

commit c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Aug 16 19:58:53 2018

DisplayRotationDefaultHandler: Use cros_display_config.mojom

Notes:
* The browser tests access ash::Shell directly so do not currently run
  with mash enabled; they will need to be re-factored (along with many
  other browser tests) to fix this.
* ShellDelegate::PreInit is required by
  window_tree_host_manager_unittest.cc. The test that uses it can
  probably just be removed; I will do that in a follow-up CL.

Bug:  705713 
Change-Id: I002ca4ce30c3a7131af4ec97916c3f0f652ec90b
Reviewed-on: https://chromium-review.googlesource.com/1168391
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583780}
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/ash/display/display_configuration_controller.cc
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/ash/display/display_configuration_controller.h
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/ash/display/display_configuration_controller_test_api.cc
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/ash/display/display_configuration_controller_test_api.h
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/ash/display/display_configuration_controller_unittest.cc
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/ash/rotator/screen_rotation_animator_unittest.cc
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/ash/test/ash_test_helper.cc
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/chrome/browser/chromeos/policy/DEPS
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/chrome/browser/chromeos/policy/display_rotation_default_handler.cc
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/chrome/browser/chromeos/policy/display_rotation_default_handler.h
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/chrome/browser/chromeos/policy/display_rotation_default_handler_browsertest.cc
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/c5acf57dc6979b2d9e7e2fcc7666ffad0fa929f7/chrome/browser/ui/ash/chrome_shell_delegate.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80

commit 6584d78b6a44b02a4c4a5fee6cf6cca431c9df80
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Aug 16 22:16:02 2018

ash::ShellDelegate: elim PreInit

ShellDelegate::PreInit is now only used by
WindowTreeHostManagerStartupTest.Startup which can effectively be tested
by other means.

Bug:  705713 
Change-Id: Ieaa394db7603ab14ccaa79059303aff4011af5d0
Reviewed-on: https://chromium-review.googlesource.com/1169432
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583850}
[modify] https://crrev.com/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80/ash/shell.cc
[modify] https://crrev.com/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80/ash/shell_delegate.h
[modify] https://crrev.com/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80/ash/shell_delegate_mash.cc
[modify] https://crrev.com/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80/ash/shell_delegate_mash.h
[modify] https://crrev.com/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80/ash/test_shell_delegate.cc
[modify] https://crrev.com/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80/ash/test_shell_delegate.h
[modify] https://crrev.com/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/6584d78b6a44b02a4c4a5fee6cf6cca431c9df80/chrome/browser/ui/ash/chrome_shell_delegate.h