New issue
Advanced search Search tips

Issue 705707 link

Starred by 1 user
Status: Fixed
Owner:
liaoyuke@chromium.org
Closed: Mar 2017
Cc:
eugene...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Write a unit tests that reloads web state with empty navigation manager

Project Member Reported by eugene...@chromium.org, Mar 27 2017 
Steps to reproduce: 
1.) Create WebState
2.) Call Reload on Navigation Manager

Observed behavior: 
In ToT app crashes

Expected behavior: 
App should not crash

Comment 1 by liaoyuke@chromium.org, Mar 27 2017

Cc: -liaoyuke@chromium.org eugene...@chromium.org
Owner: liaoyuke@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e70e89bec8b805f1056ba85e1e14c9486341d138

commit e70e89bec8b805f1056ba85e1e14c9486341d138
Author: liaoyuke <liaoyuke@chromium.org>
Date: Wed Mar 29 18:28:36 2017

Reload with empty navigation manager should not crash

Previously, the app crashes when user tries to reload when navigation
manager is empty.

This CL fixes the issue by adding an earl return to |Reload| in
NavigationManagerImpl so that it does nothing when its empty.

This CL also adds corresponding unit tests to prevent regressions.

BUG= 705707 

Review-Url: https://codereview.chromium.org/2780703002
Cr-Commit-Position: refs/heads/master@{#460464}

[modify] https://crrev.com/e70e89bec8b805f1056ba85e1e14c9486341d138/ios/web/web_state/web_state_unittest.mm

Comment 3 by liaoyuke@chromium.org, Mar 29 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment