New issue
Advanced search Search tips

Issue 705701 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Gatekeeper e-mails have invalid URL links (missing host?)

Project Member Reported by d...@chromium.org, Mar 27 2017

Issue description

See: https://screenshot.googleplex.com/s11SmOnegx2.png

This may be related to the recent Gatekeeper change to make it work with the "/varz" endpoint, so +hinoka@.
 

Comment 1 by d...@chromium.org, Apr 3 2017

Labels: -Pri-1 Pri-0
Escalating to P0, since this is causing Gatekeeper e-mails to be effectively useless, since none of the links work.
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 11 2017

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 25 2017

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: d...@chromium.org
Status: Assigned (was: Untriaged)
dnj@, is this still an issue?  If so, is it really P0 ?

Comment 5 by d...@chromium.org, May 19 2017

I don't know. I haven't received a Gatekeeper e-mail :P

Comment 6 by d...@chromium.org, May 19 2017

Cc: seanmccullough@chromium.org
Labels: -Pri-0 Pri-1
Owner: ----
Status: Available (was: Assigned)
De-escalating b/c nothing's broken. Is this still a problem, Sean/Ryan?

Comment 7 by thakis@chromium.org, May 19 2017

Labels: -Pri-1 Pri-0
Forwarded you an email I got recently (8 days ago). This still makes it super stressful when you break something.

Comment 8 by hinoka@chromium.org, May 19 2017

Owner: martiniss@chromium.org
+martiniss because I think you own gatekeeper? I'm not entirely sure how to repro this.

If you can't do this then assign it to me.

Comment 9 by d...@chromium.org, May 19 2017

Could you include the e-mail in this bug? I'm not point person on this, nor am I probably going to be the one handling it, so forwarding it to me is if limited utility.

Comment 10 by d...@chromium.org, May 19 2017

Labels: -Pri-0 Pri-1
Also this is not an emergency, and does not warrant P0.
Sure, here it is. Look for "Build 2131".
original_msg.txt
76.9 KB View Download
I'm pretty sure this has to do with the links that milo is giving gatekeeper. As far as I know, it just tries to put in whatever it gets from milo (used to be buildbot json). 
Project Member

Comment 13 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a67b42442f092b0eb05b29085886165c549bf01f

commit a67b42442f092b0eb05b29085886165c549bf01f
Author: Stephen Martinis <martiniss@chromium.org>
Date: Mon May 22 18:26:38 2017

Gatekeeper: fix waterfall url

Bug:  705701 
Change-Id: Id768ab47b57e95846e5c1f53c05f355f6595b04b
Reviewed-on: https://chromium-review.googlesource.com/510081
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/a67b42442f092b0eb05b29085886165c549bf01f/scripts/slave/unittests/gatekeeper_ng_test.py
[modify] https://crrev.com/a67b42442f092b0eb05b29085886165c549bf01f/scripts/slave/gatekeeper_ng.py

Project Member

Comment 14 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a67b42442f092b0eb05b29085886165c549bf01f

commit a67b42442f092b0eb05b29085886165c549bf01f
Author: Stephen Martinis <martiniss@chromium.org>
Date: Mon May 22 18:26:38 2017

Gatekeeper: fix waterfall url

Bug:  705701 
Change-Id: Id768ab47b57e95846e5c1f53c05f355f6595b04b
Reviewed-on: https://chromium-review.googlesource.com/510081
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/a67b42442f092b0eb05b29085886165c549bf01f/scripts/slave/unittests/gatekeeper_ng_test.py
[modify] https://crrev.com/a67b42442f092b0eb05b29085886165c549bf01f/scripts/slave/gatekeeper_ng.py

Status: Fixed (was: Available)

Sign in to add a comment