New issue
Advanced search Search tips

Issue 705691 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 638308



Sign in to add a comment

NQE should store config in a separate class

Project Member Reported by tbansal@chromium.org, Mar 27 2017 
NQE should store config in a separate class where it can be modified by different embedders. For Chrome, the config values should be set using the variation params. For Cronet, and other embedders, the config should be set by the Cronet embedder. This would make it possible for different Cronet embedders to configure NQE (which is currently not possible).
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b61964c84f3d3bdcb1f8bc0e136e992f9ae7758

commit 6b61964c84f3d3bdcb1f8bc0e136e992f9ae7758
Author: tbansal <tbansal@chromium.org>
Date: Wed Mar 29 23:53:44 2017

NQE: Make params a class

Make network quality estimator (NQE) params a class.

Next CL will move the storing of the params to the Params class
from the NQE class to make it simpler to query the params again and
again. This CL does not make any functional change.

BUG= 705691 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2775223004
Cr-Commit-Position: refs/heads/master@{#460582}

[modify] https://crrev.com/6b61964c84f3d3bdcb1f8bc0e136e992f9ae7758/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/6b61964c84f3d3bdcb1f8bc0e136e992f9ae7758/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/6b61964c84f3d3bdcb1f8bc0e136e992f9ae7758/net/nqe/network_quality_estimator_params.cc
[modify] https://crrev.com/6b61964c84f3d3bdcb1f8bc0e136e992f9ae7758/net/nqe/network_quality_estimator_params.h

Comment 2 by tbansal@chromium.org, May 8 2017

Blocking: 638308

Comment 3 by tbansal@chromium.org, Jun 27 2017

Labels: M-61
Status: Fixed (was: Started)
►

Sign in to add a comment