New issue
Advanced search Search tips

Issue 705662 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 688908



Sign in to add a comment

Remove internal usage of -webkit-user-modify from core/css

Project Member Reported by xiaoche...@chromium.org, Mar 27 2017

Issue description

To deprecate -webkit-user-modify, we need to stop using it inside Chrome.

It is currently used in core/css:
- WebKit/Source/core/css/html.css
- WebKit/Source/core/css/themeInputMultipleFields.css
 
Labels: Update-Quarterly

Comment 2 by shend@chromium.org, Apr 11 2017

Labels: Hotlist-CodeHealth

Comment 3 by suzyh@chromium.org, Jun 13 2017

Cc: -suzyh@chromium.org

Comment 4 by nainar@chromium.org, Jun 30 2017

Labels: Hotlist-Squash-A-Bug

Comment 5 by suzyh@chromium.org, Jul 3 2017

Owner: tkent@chromium.org
It looks like all but one of these usages are inside -webkit prefixed pseudo selectors.

My understanding is that the appropriate replacement is to set the attribute contentEditable=false but I'm not familiar with how these CSS files are pulled in and used by the code or where the elements that use these rules are created.

tkent: I see you've worked with these CSS files a lot before. Do you have any recommendations for how to tackle this?

Comment 6 by tkent@chromium.org, Jul 3 2017

Cc: xiaoche...@chromium.org
Components: -Blink>CSS Blink>Editing Blink>HTML
Labels: -Update-Quarterly -Hotlist-Squash-A-Bug
Owner: ----
We need to remove these instances at the same time as we remove -webkit-user-modify support.

They were added for a security reason, we need to keep these elements non-editable. However, contentEditable=false won't prohibit from adding -webkit-user-modify:read-write*.

As for pseudo elements, we need to do nothing except remove -webkit-user-modify support because web authors can't add attributes to pseudo elements.

As for <meter>, we need a special code to disable contentEditable.

I don't think this issue should be in Blink>CSS.
We should move html.css and theme*.css to core/html/.

Comment 7 by yosin@chromium.org, Oct 4 2017

Labels: Pri-3
Labels: Type-Task
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 14

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)

Sign in to add a comment