New issue
Advanced search Search tips

Issue 705656 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Expand desktop memory test coverage: Repeated open and close tabs.

Project Member Reported by erikc...@chromium.org, Mar 27 2017

Issue description

We expect the total memory usage to stay relatively constant after opening/closing many tabs.

Etienne has observed otherwise, at least partially due to a leak of mojo messages:
https://bugs.chromium.org/p/chromium/issues/detail?id=704938

We should write a new telemetry user story that is capable of observing this leak, and is capable of catching future leaks like this.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcd03964f1bcd622d1efc230d6907adec9337759

commit fcd03964f1bcd622d1efc230d6907adec9337759
Author: Etienne Bergeron <etienneb@chromium.org>
Date: Mon Jun 12 21:04:18 2017

Add benchmark for investigating memory leaks over desktop sites

This is a new version of the benchmark used to find memory leaks in the
browser process.

The browser process stay alive for the whole duration of the benchmark.
A memory dump using memory-infra is periodically taken.
An external diff tool is used to find remaining objects allocated between
two memory dumps.

see:
  https://docs.google.com/a/google.com/document/d/1ULZRYBElYmBDGswF3f4yYpl77SD9sa0RgFNfl1FueWU/edit?usp=sharing
  https://codereview.chromium.org/2906113002/

CC: erikchen@chromium.org
R: perezju@chromium.org, primiano@chromium.org
Bug:  705656 
Change-Id: I697892a6df881d19e3aace5a44e8a395717767c0
Reviewed-on: https://chromium-review.googlesource.com/530527
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478760}
[modify] https://crrev.com/fcd03964f1bcd622d1efc230d6907adec9337759/tools/perf/contrib/memory_extras/memory_extras.py
[add] https://crrev.com/fcd03964f1bcd622d1efc230d6907adec9337759/tools/perf/page_sets/desktop_memory.py

Status: Fixed (was: Assigned)

Sign in to add a comment