New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705655 link

Starred by 18 users

Issue metadata

Status: Closed
Owner: ----
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature


Show other hotlists

Hotlists containing this issue:
Chrome-ES


Sign in to add a comment

NTP content is not vertically centered on the page

Reported by ugurcan....@gmail.com, Mar 27 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.110 Safari/537.36

Steps to reproduce the problem:
1. Open NTP

What is the expected behavior?
See the attached Expected screenshot.

What went wrong?
NTP contents such as Google logo, frequently visited site thumbnails are not centered on the page. See the attached Actual screenshot.

Did this work before? No 

Chrome version: 57.0.2987.110  Channel: stable
OS Version: OS X 10.12.3
Flash Version:
 
Actual.png
653 KB View Download
Expected.png
703 KB View Download
Maybe this issue can be resolved as part of the Local NTP.
Components: -UI UI>Browser>NewTabPage
Labels: OS-Chrome OS-Linux OS-Windows
Cc: jered@chromium.org
Hi jered@, could you help in triaging this? CC'ing you because you are listed in c/b/r/local_ntp owners file. Thanks!

Comment 4 by jered@chromium.org, Mar 29 2017

Cc: treib@chromium.org
Hrm, sorry, I'm not very qualified to field visual design suggestions. I'm not sure who's thinking about visual design of the NTP these days. treib@ likely knows more. :)

Some factors to consider are what this looks like for larger screens, and what happens when one starts typing in the search box. Presently, the cursor jumps to the omnibox and the logo is hidden. I think this is supposed to demonstrate continuity and show that one can search from the omnibox. If vertical centering put it farther away, e.g. for very large screens, some of the continuity might be lost.

Comment 5 by treib@chromium.org, Mar 30 2017

Cc: rachelis@chromium.org
Labels: -Type-Bug zine-ux Type-Feature
Summary: NTP content is not vertically centered on the page (was: NTP content is not centered on the page)
+rachelis for UX.

Currently, the NTP doesn't adapt to the vertical size of the screen (or the window) at all. We *could* do that to some degree - at some point things just won't fit. It'll make all the spacing considerations a good bit more complicated.
Rachel, WDYT? Is this worth addressing, maybe as part of the upcoming desktop NTP redesign?
Labels: M-59
Status: Untriaged (was: Unconfirmed)
Seems this is a feature request, marking it as untriaged.
Could anyone from dev team please look into this issue.
Thank you!!
We can look at this as we make improvements to the desktop UX. How can we bubble this up again once we start looking at that? 
Labels: -zine-ux
Removing zine UX label for now (but keeping myself on CC). Marc - please do feel free to re-add if you were planning to come to zine ux to discuss this week. :)

Comment 9 by treib@chromium.org, Apr 3 2017

Labels: -Pri-2 -M-59 Pri-3
NextAction: 2017-06-01
Status: Available (was: Untriaged)
The NextAction date has arrived: 2017-06-01
NextAction: 2017-09-01
Not there yet. Let's look at it again a while later.
The NextAction date has arrived: 2017-09-01
Blockedon: 583289
NextAction: ----
Cc: ew...@chromium.org alcor@google.com beaudoin@chromium.org odean@chromium.org alenaf@google.com srsridhar@chromium.org rponnada@chromium.org tkonch...@chromium.org harryyu@chromium.org
 Issue 235948  has been merged into this issue.
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e8f98405f9049bd21d91c44c9abd7dd915f85d0

commit 1e8f98405f9049bd21d91c44c9abd7dd915f85d0
Author: Marc Treib <treib@chromium.org>
Date: Fri Nov 03 13:21:02 2017

Local NTP: Hide rows of MV tiles when they don't fit on screen

Bug: 755761,  705655 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icb3f651b0d9d07f5b132a7def299d6c98be47dba
Reviewed-on: https://chromium-review.googlesource.com/726079
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513758}
[modify] https://crrev.com/1e8f98405f9049bd21d91c44c9abd7dd915f85d0/chrome/browser/resources/local_ntp/local_ntp.css
[modify] https://crrev.com/1e8f98405f9049bd21d91c44c9abd7dd915f85d0/chrome/browser/resources/local_ntp/most_visited_single.css

treib@: I tested the change in latest Snapshot on the local-NTP. I personally like the old behaviour with tiles and scrollbar. I often uses smaller Chrome windows on my desktop, because I am working in other apps at the same time. But in this case now I never can use the tiles anymore, because they are completely hidden now. Before the change, users on smaller screen just needed to zoom the NTP to 90%. That fixed it for me.

It would be great, if you could rethink the change and bring back the old behavior.

Thank you very much :-)
Cc: -beaudoin@chromium.org maxwalker@chromium.org
Personally I don't really like the new behavior either, but ultimately it's not my decision. +maxwalker for UX
Hi everybody!

I'm a Top Contributor in the Spanish Chrome Forum/Community, and since version 64.0.3258.0, when the previously mentioned commit landed in stable, a lot of users came to the Forum confused because they can only see 4 tiles now. It seems that their screens resolution is very small so due to the change the last row is hidden even if they maximize the window. Zooming out is a workaround, but in my opinion it's not the best user experience because it also zooms out all of the google.com domain including search results, due to the fact that the NTP is loaded from google.com and not locally (I saw in issue 583289 you had plans on brining the NTP back locally).

Here are the threads I'm talking about:

Main thread: https://productforums.google.com/d/msg/chrome-es/lerM3Alc8jg/L-NvvkPIAgAJ
Other threads:
* https://productforums.google.com/d/msg/chrome-es/Ii2AzW8oCgI/9ijIxpdgBgAJ
* https://productforums.google.com/d/msg/chrome-es/JBwnTl1L5U0/xQsLv_ZXBAAJ
* https://productforums.google.com/d/msg/chrome-es/IFuB1j2PJxs/ngMvdcqhBwAJ
* https://productforums.google.com/d/msg/chrome-es/FWyi8PNlWuk/FGpRAT_iAAAJ

And here are some more in the English Chrome Forum (I just dit a quick search):
* https://productforums.google.com/d/msg/chrome/LSTQNwDVu-Y/YVTGuh0WAgAJ
* https://productforums.google.com/d/msg/chrome/ViYkC-FUeyc/Fcxy8QH6AQAJ
* https://productforums.google.com/d/msg/chrome/Q9YijPAurq8/Yp7ZHkxnAQAJ
* https://productforums.google.com/d/msg/chrome/LTMYWpzy05Q/njKXiCqBBAAJ

Therefore, I would like to ask whether the current design could be discussed in order to find a better solution that makes all users happy. I personally think users should be able to view all of the tiles because the opposite behavior is just taking potential off the user.

If you're ok about discussing it and we reach some consensus about what to do, I offer myself to do the changes in the code and then submit them for review, because I would like to get started contributing to Chromium :)

Thanks!
Cc: -rponnada@chromium.org -maxwalker@chromium.org ramyan@chromium.org ma...@chromium.org
Adding new NTP eng owners FYI. There's some more info and background on bug 755761 (internal-only, sorry).
Labels: NTPThumbnail
Blockedon: -583289
Cc: bklmn@chromium.org yyushkina@chromium.org
Status: Closed (was: Available)
Marking this as closed for a few reasons:
1. the major concern noted in c#18 has been fixed (for a while)
2. with M69, thumbnails have been replaced with icons, altering the overall layout of the NTP somewhat.
3. there is a min-height from the top of the screen to the fakebox that accounts for the Doodle height, so the fakebox itself is in a fixed position on the screen.

Sign in to add a comment