New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 705630 link

Starred by 2 users
Status: Fixed
Owner:
kylec...@chromium.org
Closed: Apr 2017
Cc:
danakj@chromium.org
█ fsam...@chromium.org
rjkroege@chromium.org
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Rename DisplayCompositor

Project Member Reported by kylec...@chromium.org, Mar 27 2017 
The name DisplayCompositor isn't a great name for what the code does. It handles creating MojoCompositorFrameSinks, creating cc::Displays, managing FrameSink hierarchies and informing DisplayCompositorClient about new Surfaces. 

DisplayCompositor isn't cc::Display, which is the "display compositor", and it doesn't composite things. So a new name is in order.

The public API for DisplayCompositor is similar to what cc::FrameSinkManager offers except over Mojo. DisplayCompositor also handles some cc::SurfaceManager functionality.

I would say call it FrameSinkManager but that conflicts with the existing cc::FrameSinkManager. Another option would be GpuFrameSinkManager, similar to GpuCompositorFrameSink, but we've also concluded that the new service shouldn't be called GPU because it's confusing.

Comment 1 by danakj@chromium.org, Mar 28 2017 

Is it a MojoFrameSinkManager?

Comment 2 by kylec...@chromium.org, Mar 29 2017 

That sounds fine to me, I'll use that.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/486c4556acd867e89461ff8c53f6badfe2f1b3a4

commit 486c4556acd867e89461ff8c53f6badfe2f1b3a4
Author: kylechar <kylechar@chromium.org>
Date: Tue Apr 04 15:31:44 2017

Rename DisplayCompositor to MojoFrameSinkManager.

The DisplayCompositor class and interface names are inaccurate. It is
not a per display thing and it doesn't composite. We also already have a
"display compositor" which is something separate.

What was called DisplayCompositor actually manages CompositorFrameSinks.
In the future it will manage other kinds of FrameSinks.

Rename the interface to mojom::FrameSinkManager and implementation to
MojoFrameSinkManager.

Also remove cc::mojom::FrameSinkManager from manifests. This is a
privileged interface only for service:ui not window_manager + apps.

BUG= 705630 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2797453002
Cr-Commit-Position: refs/heads/master@{#461727}

[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/cc/ipc/BUILD.gn
[rename] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/cc/ipc/frame_sink_manager.mojom
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/components/display_compositor/gpu_compositor_frame_sink.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/components/display_compositor/gpu_root_compositor_frame_sink.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager_unittest.cc
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/content/browser/renderer_host/offscreen_canvas_surface_factory_impl.cc
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/content/browser/renderer_host/offscreen_canvas_surface_factory_impl.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/content/browser/renderer_host/offscreen_canvas_surface_impl.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/content/gpu/gpu_child_thread.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/common/BUILD.gn
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/gpu/gpu_main.cc
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/gpu/gpu_main.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/gpu/interfaces/gpu_main.mojom
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/gpu/interfaces/gpu_service.mojom
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/manifest.json
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/surfaces/BUILD.gn
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/surfaces/display_provider.h
[rename] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/surfaces/mojo_frame_sink_manager.cc
[rename] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/surfaces/mojo_frame_sink_manager.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/display_client_compositor_frame_sink.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/gpu_host.cc
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/gpu_host.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/server_window.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/server_window_compositor_frame_sink_manager.cc
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/server_window_compositor_frame_sink_manager.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/server_window_delegate.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/test_server_window_delegate.cc
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/test_server_window_delegate.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/window_server.cc
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/services/ui/ws/window_server.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h
[modify] https://crrev.com/486c4556acd867e89461ff8c53f6badfe2f1b3a4/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom

Comment 4 by kylec...@chromium.org, Apr 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment