New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 705627 link

Starred by 1 user
Status: Fixed
Owner:
█ lgar...@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 571506



Sign in to add a comment

Rename WebSiteSettingsPopupViewBrowserTest to PageInfoPopupViewBrowserTest

Project Member Reported by lgar...@chromium.org, Mar 27 2017 
I think I missed this one due to case differences.

Based on a manual look through all (case-insensitive) remaining occurrences of "WebsiteSettings", this appears to be the only one apart from  Issue 705355 .

Comment 1 by lgar...@chromium.org, Mar 27 2017 

Yep, I accidentally did a no-op replacement due to the existing case typo: https://github.com/lgarron/website-settings-to-page-info/blob/923b2fac512fe974783c918b48a42346d8430ad8/page_info.fish#L207

My editor must have been in case-sensitive search mode when I was constructing the rewritten strings.

Comment 2 by lgar...@chromium.org, Mar 27 2017

Summary: Rename WebSiteSettingsPopupViewBrowserTest to PageInfoPopupViewBrowserTest (was: Rename WebSiteSettingsPopupViewBrowserTest to PageInfoPopupViewBrowserTest;)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/625dec950fc94b1678646d4d5ef19b76c49c96db

commit 625dec950fc94b1678646d4d5ef19b76c49c96db
Author: lgarron <lgarron@chromium.org>
Date: Mon Mar 27 21:49:35 2017

Rename WebSiteSettingsPopupViewBrowserTest to PageInfoPopupViewBrowserTest.

BUG= 705627 

Review-Url: https://codereview.chromium.org/2778043002
Cr-Commit-Position: refs/heads/master@{#459893}

[modify] https://crrev.com/625dec950fc94b1678646d4d5ef19b76c49c96db/chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc

Comment 4 by lgar...@chromium.org, Mar 27 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment