New issue
Advanced search Search tips

Issue 705626 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Fix duplicate test names in LayoutTests/svg/

Project Member Reported by f...@opera.com, Mar 27 2017

Issue description

The following is cut'n'pasted from https://codereview.chromium.org/2766823003

third_party/WebKit/LayoutTests/svg/css/baseline-shift-inherit-expected.txt
third_party/WebKit/LayoutTests/svg/css/path-element-expected.txt
third_party/WebKit/LayoutTests/svg/custom/getBBox-circle-has-one-zero-value-expected.txt
third_party/WebKit/LayoutTests/svg/custom/getBBox-ellipse-has-one-zero-value-expected.txt
third_party/WebKit/LayoutTests/svg/custom/getBBox-rect-has-one-zero-value-expected.txt
third_party/WebKit/LayoutTests/svg/dom/svgangle-units-expected.txt
third_party/WebKit/LayoutTests/svg/dom/tabindex-focus-expected.txt
third_party/WebKit/LayoutTests/svg/in-html/sizing/svg-inline-vertical-expected.txt

and contains one or more duplicated testnames.
 
Labels: Test-Layout BugSource-Team PaintTeamTriaged-20170327
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9637327dcc73c3d4abc94874d353e093436fe49

commit e9637327dcc73c3d4abc94874d353e093436fe49
Author: fs <fs@opera.com>
Date: Wed Mar 29 17:49:05 2017

Deduplicate testharness test names in LayoutTests/svg/

Some tests were using non-unique names, which triggers a harness error
for "newer" versions of testharness.js.
Twiddle the relevant names a bit so that they become unique.

BUG= 705626 

Review-Url: https://codereview.chromium.org/2782583002
Cr-Commit-Position: refs/heads/master@{#460447}

[delete] https://crrev.com/005c499ef546afe661c7922f2a03e81dd62ff06e/third_party/WebKit/LayoutTests/svg/css/baseline-shift-inherit-expected.txt
[modify] https://crrev.com/e9637327dcc73c3d4abc94874d353e093436fe49/third_party/WebKit/LayoutTests/svg/css/baseline-shift-inherit.html
[delete] https://crrev.com/005c499ef546afe661c7922f2a03e81dd62ff06e/third_party/WebKit/LayoutTests/svg/css/path-element-expected.txt
[modify] https://crrev.com/e9637327dcc73c3d4abc94874d353e093436fe49/third_party/WebKit/LayoutTests/svg/css/path-element.html
[delete] https://crrev.com/005c499ef546afe661c7922f2a03e81dd62ff06e/third_party/WebKit/LayoutTests/svg/custom/getBBox-circle-has-one-zero-value-expected.txt
[modify] https://crrev.com/e9637327dcc73c3d4abc94874d353e093436fe49/third_party/WebKit/LayoutTests/svg/custom/getBBox-circle-has-one-zero-value.html
[delete] https://crrev.com/005c499ef546afe661c7922f2a03e81dd62ff06e/third_party/WebKit/LayoutTests/svg/custom/getBBox-ellipse-has-one-zero-value-expected.txt
[modify] https://crrev.com/e9637327dcc73c3d4abc94874d353e093436fe49/third_party/WebKit/LayoutTests/svg/custom/getBBox-ellipse-has-one-zero-value.html
[delete] https://crrev.com/005c499ef546afe661c7922f2a03e81dd62ff06e/third_party/WebKit/LayoutTests/svg/custom/getBBox-rect-has-one-zero-value-expected.txt
[modify] https://crrev.com/e9637327dcc73c3d4abc94874d353e093436fe49/third_party/WebKit/LayoutTests/svg/custom/getBBox-rect-has-one-zero-value.html
[delete] https://crrev.com/005c499ef546afe661c7922f2a03e81dd62ff06e/third_party/WebKit/LayoutTests/svg/dom/svgangle-units-expected.txt
[modify] https://crrev.com/e9637327dcc73c3d4abc94874d353e093436fe49/third_party/WebKit/LayoutTests/svg/dom/svgangle-units.html
[delete] https://crrev.com/005c499ef546afe661c7922f2a03e81dd62ff06e/third_party/WebKit/LayoutTests/svg/dom/tabindex-focus-expected.txt
[modify] https://crrev.com/e9637327dcc73c3d4abc94874d353e093436fe49/third_party/WebKit/LayoutTests/svg/dom/tabindex-focus.html
[delete] https://crrev.com/005c499ef546afe661c7922f2a03e81dd62ff06e/third_party/WebKit/LayoutTests/svg/in-html/sizing/svg-inline-vertical-expected.txt
[modify] https://crrev.com/e9637327dcc73c3d4abc94874d353e093436fe49/third_party/WebKit/LayoutTests/svg/in-html/sizing/svg-inline-vertical.html

Comment 3 by f...@opera.com, Mar 29 2017

Status: Fixed (was: Assigned)

Sign in to add a comment