New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705616 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-40% regression in media.tough_video_cases at 459388:459639

Project Member Reported by dalecurtis@google.com, Mar 27 2017

Issue description

Buffering 2 seconds shows a mixture of improvements and regressions, this is a tracking bug for all of them to decide if there's anything actionable.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=705616

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7LTWugkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7JT2rgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7LTCqwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7KuQvgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7PC5qwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrPj14gkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7JS9oQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrK-MqAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7JLktAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrKKymAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrLrQ_wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrLrv9AsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7Mb4qgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7ICO-woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7LD8sAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrN2vswoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrJ3p4AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrP6OsQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7ITu5QkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrMmL9QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrK6YnwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7LzQ9wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrJ29sQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrIvFvwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7PrEtgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrPj14goM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7O7qtwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrJ6ouwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7PrEtgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgzLOPrggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrN65tAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrJn7sgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgzOX70AkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrJ32vgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrMbxrAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrJ68pgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrPf9qQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrK6Y7wsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrO73qgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrI7JlQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7LrfpwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrMS6-AsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrI7JlQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrLzF6gsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7MCw_wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7Ny9uwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7Nz2swkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7KD47QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrM704wkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrOf38ggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrPPWvQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7ITu5QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7ITu5QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7KTOsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrMbmtQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrLeIvQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7MTrtgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrNqnrgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrMS6-AoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrM704woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrJe8ugsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7LzMrgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7KD47QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrJr65AsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7ODloAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrP79uQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7Lje_QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7LyV8AoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrNOnjgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7OTwtQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7PqOvgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7PqSrwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7OTsrAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7LrhsgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrN7DrQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrK2D5QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrNOnjgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrIf4sAgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7KTZqAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7MLxpAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrJmWrQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7MKYsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgzPTShAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrNrp5goM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrJXQkggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrL_X8QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7MK7rAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7NrysAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrPOirAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrK67uQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrPO4tQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgzMeKiQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7JDYuQoM


Bot(s) for this bug's original alert(s):

android-nexus5X
android-nexus7v2
chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual

Comment 3 by hubbe@chromium.org, Mar 27 2017

TL;DR:

a surprisingly small increase in memory (1-2 kb, if the units in the dashboard are correct.)
idle wakeups go down by a good 15-20%
seek time for webm go up by 10-20%

The seek time seems bad, and there doesn't seem to be much data to back up
any improvements. Maybe I should revert it, add some tests that would show
improvements and then try submit it again?

Hmm, did you click show improvements at the top right? I saw quite a few.

Comment 5 by hubbe@chromium.org, Mar 27 2017

Nope, missed that. Doesn't seem to do anything though.
(I follow the "All graphs for this bug" link, and then click that button.)

The "Original alerts at time of bug-filing" link doesn't work, I guess it's too long.

Comment 7 by hubbe@chromium.org, Mar 27 2017

Interesting, summarizing this link:

Major improvements for "buffering_time". (20-650%)  (Why is this negative??)
clockless video playback improves (2-13 %)
idle_wakup_renderer improves (30-60%)
time to play improves across the board (10-30%)
seek improves in more cases than it regresses (-20 - +40%)

Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Mar 28 2017

Cc: hubbe@chromium.org

=== Auto-CCing suspected CL author hubbe@chromium.org ===

Hi hubbe@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : hubbe
  Commit : 83bbe324e42ebe5b1205d6caeb1ea4149bad31f1
  Date   : Fri Mar 24 21:48:44 2017
  Subject: Buffer 2 seconds of data in the ffmpeg demuxer.

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : media.android.tough_video_cases
  Metric       : vm_private_dirty_delta/crowd.wav_renderer
  Change       : 26.98% | 2260.66666667 -> 2870.66666667

Revision             Result                  N
chromium@459484      2260.67 +- 66.3124      6      good
chromium@459529      2264.67 +- 25.5604      6      good
chromium@459551      2249.33 +- 58.697       6      good
chromium@459562      2263.33 +- 49.1257      6      good
chromium@459564      2267.33 +- 61.0355      6      good
chromium@459565      2876.0 +- 70.6541       6      bad       <--
chromium@459568      2865.33 +- 57.3178      6      bad
chromium@459573      2870.67 +- 59.2396      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests media.android.tough_video_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983944436074237760

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5687071785615360


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Apr 11 2017

Cc: wolenetz@chromium.org crouleau@chromium.org
 Issue 710130  has been merged into this issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 21 2017

Labels: Hotlist-Google
Status: WontFix (was: Assigned)

Sign in to add a comment