New issue
Advanced search Search tips

Issue 705602 link

Starred by 2 users
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 672512



Sign in to add a comment

should.beEqualToArray should support Uint8Array

Project Member Reported by rtoy@chromium.org, Mar 27 2017 
beEqualToArray fails if the expected (or actual) array is a Uint8Array.  getByteFrequencyData returns a Uint8Array.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89a520a13e387fc2331943aeb451b16026e9e00e

commit 89a520a13e387fc2331943aeb451b16026e9e00e
Author: rtoy <rtoy@chromium.org>
Date: Tue Mar 28 16:44:42 2017

Audit should support Uint8Arrays

Allow should() to recognize Uint8Arrays for the actual results.
Previously, this would just return "undefined", and allow the test to
pass, which is incorrect.

BUG= 705602 
TEST=unit-tests/audit.html

Review-Url: https://codereview.chromium.org/2781643002
Cr-Commit-Position: refs/heads/master@{#460128}

[modify] https://crrev.com/89a520a13e387fc2331943aeb451b16026e9e00e/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
[modify] https://crrev.com/89a520a13e387fc2331943aeb451b16026e9e00e/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
[modify] https://crrev.com/89a520a13e387fc2331943aeb451b16026e9e00e/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html

Comment 2 by rtoy@chromium.org, Mar 29 2017

Status: Fixed (was: Started)
►

Sign in to add a comment