OS: all Places to update: Desktop (1) Password location bar icon (2) Password generation dropdown Mobile (1) Password save and update prompt infobar (2) Password generation dropdown Current asset: go/crpwic New asset: go/crpwin UI review: https://groups.google.com/a/google.com/forum/#!searchin/chrome-ui-review/icon$20password$20hwi%7Csort:date/chrome-ui-review/Xeje8jroIOo/tASDlnrdAwAJ Important note: The omnibox icon on desktop should be in *gray not blue* (per the latest guideline on the omnibox icons). Contact: hwi@
+cc dvadym@ and kolos@ for generation in particular; we should make sure this is updated before the launch.
The screenshots for Linux platform; location bar & password generation dropdown are attached.
The screenshots for Mac platform; location bar & password generation dropdown are attached.
Ui update for password generation box: Image is 16 pixels and have 16 pixel margin for linux & mac platforms. Requested by maxwalker@ Screenshots attached.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd1656e915d483c1c190c67917c3ab2a3cc91baa commit fd1656e915d483c1c190c67917c3ab2a3cc91baa Author: Irmak Kavasoğlu <irmakk@google.com> Date: Wed Aug 23 09:01:06 2017 Updated key icon for generating password & manage passwords bubble on desktop The autologin.icon file update will be used in all desktop platforms, for password generation drop downs and the password manager icon in the address bar. The png file was in use by mac platform only, for password generation drop down only. Removed, now mac platform also uses the icon file. There was also design update, requested by maxwalker@, for screenshots please refer to the bug comments. Bug: 705597 Change-Id: I8e33ec422639b95a1184ae5e12e59deb8a6a58ca Reviewed-on: https://chromium-review.googlesource.com/603653 Reviewed-by: Rachel Blum <groby@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Irmak Kavasoğlu <irmakk@google.com> Cr-Commit-Position: refs/heads/master@{#496636} [delete] https://crrev.com/8a428a0569624bd59110975231eb32141e75abd7/chrome/app/theme/default_100_percent/legacy/password_generation_key.png [delete] https://crrev.com/8a428a0569624bd59110975231eb32141e75abd7/chrome/app/theme/default_200_percent/legacy/password_generation_key.png [modify] https://crrev.com/fd1656e915d483c1c190c67917c3ab2a3cc91baa/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/fd1656e915d483c1c190c67917c3ab2a3cc91baa/chrome/app/vector_icons/BUILD.gn [delete] https://crrev.com/8a428a0569624bd59110975231eb32141e75abd7/chrome/app/vector_icons/autologin.icon [add] https://crrev.com/fd1656e915d483c1c190c67917c3ab2a3cc91baa/chrome/app/vector_icons/key.icon [modify] https://crrev.com/fd1656e915d483c1c190c67917c3ab2a3cc91baa/chrome/browser/ui/autofill/password_generation_popup_controller.h [modify] https://crrev.com/fd1656e915d483c1c190c67917c3ab2a3cc91baa/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm [modify] https://crrev.com/fd1656e915d483c1c190c67917c3ab2a3cc91baa/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm [modify] https://crrev.com/fd1656e915d483c1c190c67917c3ab2a3cc91baa/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm [modify] https://crrev.com/fd1656e915d483c1c190c67917c3ab2a3cc91baa/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc [modify] https://crrev.com/fd1656e915d483c1c190c67917c3ab2a3cc91baa/chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc
Comment 1 by vabr@chromium.org
, Apr 13 2017Labels: tracking_work
Status: Available (was: Untriaged)