New issue
Advanced search Search tips

Issue 705593 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update name of android port in webkitpy/layout_tests/port/android.py

Project Member Reported by qyears...@chromium.org, Mar 27 2017

Issue description

Currently, the port name used in android.py is "icecreamsandwich" (version 4.0 - 4.0.4). However, looking at the "device status" info from WebKit Android (Nexus4) (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/62855), it says version is KOT49H (version 4.4.2), and for android_blink_rel it says version is KTU84P (version 4.4.4).

jbudorick@, do you know if it would make sense to just change this name to "kitkat"?


Relatedly: in webkitpy/common/config/builders.py, for most builders, the most specific version is listed, but for the android builders, "Android" is listed instead of the specific version port name "Icecreamsandwich", which is a bit inconsistent.
 
Cc: qyears...@chromium.org
Status: Available (was: Unconfirmed)
You could. I'm not that familiar with what the version/FALLBACK_PATHS are used for, but as long as there's an entry in FALLBACK_PATHS for what version returns, it seems like it should be fine.

As AndroidPort operates with multiple devices, it's may be tricky to actually report the version in use, as there may be more than one. In theory, though, "version" should probably be whatever ro.build.version.release is set to on the device (which, surprisingly, we don't have a property for in device_utils).
Cc: -qyears...@chromium.org
Owner: qyears...@chromium.org
Status: Assigned (was: Available)
Alright, so using any particular version name is probably not going to remain accurate for very long, but for now, "icecreamsandwich" is a bit more misleading than "kitkat", and that should be a quick/simple change.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f36c8ad44b223f425bd87e2cd26de9bf35afaec

commit 8f36c8ad44b223f425bd87e2cd26de9bf35afaec
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Mar 30 23:43:38 2017

Replace the string "icecreamsandwich" with "kitkat" in Port classes.

I don't expect this change to have any effect on behavior.

BUG= 705593 

Review-Url: https://codereview.chromium.org/2789713002
Cr-Commit-Position: refs/heads/master@{#460933}

[modify] https://crrev.com/8f36c8ad44b223f425bd87e2cd26de9bf35afaec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/8f36c8ad44b223f425bd87e2cd26de9bf35afaec/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10680ded1bf7a68d8f9a05dd8dd9b378817bbe1b

commit 10680ded1bf7a68d8f9a05dd8dd9b378817bbe1b
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Mar 31 17:28:23 2017

Change builder config so that android also uses specific version names.

This would make it so that the entries for the android builders
(continuous and try bot) have a specific version in the port name
and specifier.

This shouldn't change behavior when running the tests, I believe.

The original motivation for this change was to make it so that the
update-test-expectations script finds the android builder correctly. That
script iterates through all possible configurations and finds builders
that match; previously it was trying to find any builder that matched
the specific port "icecreamsandwich" but was unable to find any android
builder that matched since there was none in common/config/builders.py.

BUG= 705593 

Review-Url: https://codereview.chromium.org/2786993004
Cr-Commit-Position: refs/heads/master@{#461160}

[modify] https://crrev.com/10680ded1bf7a68d8f9a05dd8dd9b378817bbe1b/third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.py

Status: Fixed (was: Assigned)

Sign in to add a comment