New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705592 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 729798
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 706246
issue 707076
issue 731255



Sign in to add a comment

Make AshNativeCursorManager work in Config::MUS

Project Member Reported by sky@chromium.org, Mar 27 2017

Issue description

This class, among other things, controls the native cursor. It needs to be made to work in Config::MUS.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a

commit 494c6cbdea529cc6aa1e4e344bdc732d61d91d3a
Author: sky <sky@chromium.org>
Date: Mon Mar 27 20:57:48 2017

Gets chrome --mus some what working

This makes chrome work in --mus mode. It comes up and displays stuff,
but I have no doubt a bunch of stuff doesn't work.

BUG= 704985 , 705592 , 705595 , 705591 , 678949 
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2777223002
Cr-Commit-Position: refs/heads/master@{#459875}

[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/common/wm_shell.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager_application.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/public/cpp/BUILD.gn
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/public/cpp/config.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/shell.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/shell.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/test/ash_test_helper.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/ash_config.cc
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/ash_config.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_init.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_util.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_util.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/frame/native_browser_frame_factory_chromeos.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_tree_client.h

Comment 2 by sky@chromium.org, Mar 29 2017

Owner: e...@chromium.org
Status: Assigned (was: Untriaged)
More cursor related classes...

Comment 3 by sky@chromium.org, Mar 29 2017

Blocking: 706246

Comment 4 by sky@chromium.org, Mar 30 2017

Blocking: 707076

Comment 5 by sky@chromium.org, Jun 8 2017

Blocking: 731255

Comment 6 by e...@chromium.org, Aug 11 2017

Mergedinto: 729798
Status: Duplicate (was: Assigned)
This was done in a different bug.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2920dfe1c88deaf619a76c3189da7b331ca5957

commit f2920dfe1c88deaf619a76c3189da7b331ca5957
Author: James Cook <jamescook@chromium.org>
Date: Tue Sep 04 19:55:01 2018

chromeos: Eliminate ash::Config::MASH_DEPRECATED

We haven't run ash in this mode for months, since the switch to ws2 /
window-service-as-a-library.

* CursorManager exists in ws2, so always use it
* Docked magnifier works in SingleProcessMash, and will need to be
  fixed separately for multi-process
* Eliminate unused DragWindowResizerMash. Window dragging across
  displays works for both single-process and multi-process mash
* Always use EventTargetingPolicy::TARGET_AND_DESCENDENTS in exo.
  Manually verified that clicks go to the right place in both
  single-process and multi-process mash.
* Remove many unused includes

I had to disable one ash_unittest for NonClientFrameController.

TBR=lhchavez@chromium.org

Bug:  631103 ,  637853 ,  646565 ,  705592 ,  756163 , 839521
Test: ash_unittests
Change-Id: Iab64339029a33921274089ca4cb57a8f037f6f88
Reviewed-on: https://chromium-review.googlesource.com/1200483
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588626}
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/BUILD.gn
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/accessibility/accessibility_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/app_list/app_list_controller_impl.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/dbus/ash_dbus_services.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/display_prefs.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/mirror_window_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/frame/header_view.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/highlighter/highlighter_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/ime/ime_focus_handler_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/keyboard/virtual_keyboard_controller.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/keyboard/virtual_keyboard_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/laser/laser_pointer_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/login/ui/lock_screen_sanity_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/login/ui/login_password_view_test.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/login/ui/login_test_base.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/metrics/login_metrics_recorder_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/public/cpp/BUILD.gn
[delete] https://crrev.com/62ebf0a512c16992819b555014cdd9ce6ade383e/ash/public/cpp/config.h
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/root_window_controller.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/app_list_button_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_context_menu_model_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_controller.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_tooltip_manager.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_tooltip_manager_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shell.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shell.h
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shell_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/flag_warning/flag_warning_tray.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/message_center/notification_tray_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/network/tray_network_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/network/wifi_toggle_notification_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/night_light/night_light_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/night_light/tray_night_light_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/palette/palette_tray_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/palette/tools/screenshot_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/power/peripheral_battery_notifier_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/power/power_button_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/session/logout_button_tray_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/status_area_widget.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/status_area_widget_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/tray/system_tray.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/tray_caps_lock.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/unified/unified_system_tray_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/test/ash_test_base.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/test/ash_test_base.h
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/tooltips/tooltip_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/touch/touch_observer_hud_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wayland/wayland_server_controller.cc
[delete] https://crrev.com/62ebf0a512c16992819b555014cdd9ce6ade383e/ash/wm/drag_window_resizer_mash.cc
[delete] https://crrev.com/62ebf0a512c16992819b555014cdd9ce6ade383e/ash/wm/drag_window_resizer_mash.h
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/system_modal_container_layout_manager.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/window_util.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/chrome/browser/ui/ash/ash_util.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/components/arc/rotation_lock/arc_rotation_lock_bridge.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/components/exo/shell_surface_base.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/components/exo/wayland/clients/test/wayland_client_test.cc
[modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/testing/buildbot/filters/chromeos.single_process_mash.fyi.ash_unittests.filter

Sign in to add a comment