New issue
Advanced search Search tips

Issue 705591 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 839265



Sign in to add a comment

chromeos::Preferences needs access to display_manager

Project Member Reported by sky@chromium.org, Mar 27 2017

Issue description

To toggle unified desktop.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a

commit 494c6cbdea529cc6aa1e4e344bdc732d61d91d3a
Author: sky <sky@chromium.org>
Date: Mon Mar 27 20:57:48 2017

Gets chrome --mus some what working

This makes chrome work in --mus mode. It comes up and displays stuff,
but I have no doubt a bunch of stuff doesn't work.

BUG= 704985 , 705592 , 705595 , 705591 , 678949 
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2777223002
Cr-Commit-Position: refs/heads/master@{#459875}

[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/common/wm_shell.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager_application.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/public/cpp/BUILD.gn
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/public/cpp/config.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/shell.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/shell.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/test/ash_test_helper.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/ash_config.cc
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/ash_config.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_init.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_util.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_util.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/frame/native_browser_frame_factory_chromeos.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_tree_client.h

Comment 2 by sky@chromium.org, Jun 8 2017

Blocking: 731255

Comment 3 by sky@chromium.org, Jul 19 2017

Blocking: -731255
See chrome/browser/chromeos/display/display_preferences.cc for code using DislayManager.

With simplified display management this works fine for mushrome, but not mash. I'm removing this as a blocker for mushrome.
Blocking: 839265
Cc: jamescook@chromium.org
Owner: steve...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bce1cf5ce7492bed1ef10dca5bd5807c18ff246b

commit bce1cf5ce7492bed1ef10dca5bd5807c18ff246b
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed May 23 19:38:12 2018

chromeos::Preferences: Use mojo API to set unified desktop

This includes some additional cleanup of unnecessary display_manager.h
includes.

For trivial include fix to overlay/overlay_window_views.cc:
TBR=msw@chromium.org

Bug:  705591 
Change-Id: Ide2da67745f80e641a393c447d3c448e53783f30
Reviewed-on: https://chromium-review.googlesource.com/1069534
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Philipp Weiß <phweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561207}
[modify] https://crrev.com/bce1cf5ce7492bed1ef10dca5bd5807c18ff246b/chrome/browser/chromeos/DEPS
[modify] https://crrev.com/bce1cf5ce7492bed1ef10dca5bd5807c18ff246b/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc
[modify] https://crrev.com/bce1cf5ce7492bed1ef10dca5bd5807c18ff246b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/bce1cf5ce7492bed1ef10dca5bd5807c18ff246b/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/bce1cf5ce7492bed1ef10dca5bd5807c18ff246b/chrome/browser/chromeos/preferences.h
[modify] https://crrev.com/bce1cf5ce7492bed1ef10dca5bd5807c18ff246b/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/bce1cf5ce7492bed1ef10dca5bd5807c18ff246b/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.cc
[modify] https://crrev.com/bce1cf5ce7492bed1ef10dca5bd5807c18ff246b/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/bce1cf5ce7492bed1ef10dca5bd5807c18ff246b/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.cc

Status: Fixed (was: Started)

Sign in to add a comment