New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705577 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 706881



Sign in to add a comment

make the backdrop in Tablet mode fully opaque

Project Member Reported by osh...@chromium.org, Mar 27 2017

Issue description

make the backdrop in Tablet mode fully opaque
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/634e30f551f032ce930a65932c1bfad403c9c8d2

commit 634e30f551f032ce930a65932c1bfad403c9c8d2
Author: oshima <oshima@chromium.org>
Date: Tue Mar 28 16:23:08 2017

Make backdrop fully opaque

BUG= 705577 

Review-Url: https://codereview.chromium.org/2775353002
Cr-Commit-Position: refs/heads/master@{#460118}

[modify] https://crrev.com/634e30f551f032ce930a65932c1bfad403c9c8d2/ash/common/wm/maximize_mode/workspace_backdrop_delegate.cc

Comment 2 by osh...@chromium.org, Mar 28 2017

Labels: ReleaseBlock-Stable Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 29 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by osh...@chromium.org, Mar 29 2017

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b53a0d0ca06e4ef85adfcb8357a95fb33ebd6710

commit b53a0d0ca06e4ef85adfcb8357a95fb33ebd6710
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Mar 30 01:26:51 2017

Make backdrop fully opaque

BUG= 705577 

Review-Url: https://codereview.chromium.org/2775353002
Cr-Commit-Position: refs/heads/master@{#460118}
(cherry picked from commit 634e30f551f032ce930a65932c1bfad403c9c8d2)

Review-Url: https://codereview.chromium.org/2780333002 .
Cr-Commit-Position: refs/branch-heads/3029@{#485}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/b53a0d0ca06e4ef85adfcb8357a95fb33ebd6710/ash/common/wm/maximize_mode/workspace_backdrop_delegate.cc

Status: Started (was: Fixed)
Found that the backdrop doesn't cover entire display, so the wallpapper is visible through shelf. We need one more change.
Blockedon: 706881
Status: Fixed (was: Started)
Components: UI>Shell

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment