New issue
Advanced search Search tips

Issue 705574 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 595538

Blocking:
issue 671375



Sign in to add a comment

MD Settings: Passwords need tooltip

Project Member Reported by hcarmona@chromium.org, Mar 27 2017

Issue description

Created from:  Issue 595538 

Missing functionality from Comment #23:

Hiding the scheme of the origins and showing the full url in the tooltip? It is how it looks like now. We come up to this solution with UX and security team.
 
Owner: hcarmona@chromium.org
Status: Started (was: Untriaged)
Taking ownership.
Cc: kolos@chromium.org bettes@chromium.org
Screenshot of what this will look like.

+bettes and +kolos in case either of you would like to comment on tooltip.
Screen Shot 2017-03-27 at 6.10.20 PM.png
29.1 KB View Download
Updated screenshot from code review.
tooltip.png
37.1 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0484f901c29bf0ad0a007cf86b66677a4da57de9

commit 0484f901c29bf0ad0a007cf86b66677a4da57de9
Author: hcarmona <hcarmona@chromium.org>
Date: Wed Mar 29 00:52:36 2017

MD Settings: Show password tooltip for full URL.

Screenshot in the bug.

R=dschuyler@chromium.org
BUG= 705574 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2777063005
Cr-Commit-Position: refs/heads/master@{#460251}

[modify] https://crrev.com/0484f901c29bf0ad0a007cf86b66677a4da57de9/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Comment 5 by kolos@chromium.org, Mar 29 2017

Hi Hector,

Thanks a lot for screenshots and for the fix. Could we remove the schema from the displayed origin since it is available in the tooltip now?

Regards,
Maxim
Created  Issue 707296  to track changing how we display the schema. (To avoid cluttering this issue)

Closing this issue.
Status: Fixed (was: Started)
Labels: TE-Verified-M59 TE-Verified-59.0.3061.3
Tested the issue on Latest Dev# 59.0.3061.3 on Windows & Mac and Dev# 59.0.3061.0 on Ubuntu and found the issue to be fixed.
Observing tooltip under Manage passwords section under chrome://md-settings.
Hence adding TE-Verified labels.
Attaching screen shot for reference.
Thank You.
705574.png
68.3 KB View Download

Sign in to add a comment