Putting into ash triage queue.

Steven, who does work on gn issues nowadays? Can you please triage? Thanks!

Anyone willing and able? It can sit on my plate, but it will sit here for a while.

dpranke@ is super helpful about answering any questions for anyone who picks this up.

Are there any more details available? What is gn check?

"gn check" is a command that verifies all the #includes in your cc files match with the allowed dependencies in your BUILD.gn files. c/b/chromeos has a bunch of temporary exclusions that need to be cleaned up.

You can run "gn check" from the command line. Just point it at your out directory.

Will take this for the next starter, if that's OK.

Ben, this should give you an oppty to try out building Chrome

I'm getting started on this.  The biggest problem seems to be a cyclic dependency between //chrome/browser:browser and //chrome/browser/chromeos:chromeos.  Do you have any pointers for how to break the cycle?

In some cases we allow cyclic dependencies. See
gn's allow_circular_includes_from. We use it in chrome/browser/BUILD.gn for
one.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42137002fceb08c470f330b1b6a93bea7a0cd0f7

commit 42137002fceb08c470f330b1b6a93bea7a0cd0f7
Author: Earl Ou <shunhsingou@chromium.org>
Date: Wed Jun 07 06:07:19 2017

Move arc_tracing_agent.* to content/public

arc_tracing_agent.h is used in //chrome/browser/chromeos/arc. Move both
files to content/public to export it correctly.

BUG= 705567 

Change-Id: Ica7b880bfcd8d1ab02732f4c9ca8462b3e05ad8e
Reviewed-on: https://chromium-review.googlesource.com/523483
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Commit-Queue: Shun-Hsing Ou <shunhsingou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477560}
[delete] https://crrev.com/6a40e94018f930fd154f12a309b0a211e9e5f915/chrome/browser/chromeos/arc/tracing/DEPS
[modify] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.h
[modify] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/content/browser/BUILD.gn
[modify] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/content/browser/tracing/tracing_controller_impl.cc
[modify] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/content/public/browser/BUILD.gn
[rename] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/content/public/browser/arc_tracing_agent.cc
[rename] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/content/public/browser/arc_tracing_agent.h

Not sure where the bugdroid comment went, but I submitted http://crrev.com/c/516565 yesterday to enable gn check.

Woo hoo! Thanks for taking care of this.