New issue
Advanced search Search tips

Issue 705561 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 707006



Sign in to add a comment

[WPT Export] Document how to put the exporter in --dry-run mode with a CL if misbehaving

Project Member Reported by jeffcarp@chromium.org, Mar 27 2017

Issue description

If the exporter starts misbehaving, anyone on Chrome Infra should be able to turn it off quickly.

----------

(keeping previous description around)

What I'm imagining:

A very simple App Engine app that serves two pages:

/              The index page with a login button if the user is not logged in.
               If the user is logged in and is an admin  (we could add everyone 
               in the chrome-infra MDB group as an admin), there'd be a giant 
               ON/OFF button
/control.json  A JSON blob of the following:

{
  "dry_run": true // controls whether --dry-run is on or off
}

On the WPT Exporter side, we could add a flag --remote-control-url to tell the Exporter to read in configuration options from that URL. e.g.
./wpt-exporter --gh-user=... --gh-token=... --remote-control-url=https://wpt-exporter.appspot.com/control.json

For documentation, we could add "if the WPT Exporter is misbehaving, the first thing to do is go to the WPT Exporter control app and flip it to OFF."
 
Description: Show this description
Cc: hinoka@chromium.org
Components: Infra>Platform>Milo
That sounds like it may be useful :-) I wonder though if we're thinking too specific - I think you had a conversation before (on the hangout?) about how to stop future builds from being scheduled, as opposed to to just stopping the current build.

hinoka@, do you know if this could be a potential feature of LUCI/Milo for all builders? Like, a "pause scheduler" button or something on the page for a builder?

Comment 3 by hinoka@chromium.org, Mar 27 2017

Components: -Infra>Platform>Milo Infra>Platform>Scheduler
For continuous builds, right?

It could certainly be a potential feature but I don't think anyones talked about it.  Rerouting this one to the luci scheduler component.

It may be worth filing a separate bug for that
Yeah, for continuous builders; thanks for rerouting; filed separate  bug 705588 .

If this isn't something that we would want to add to the LUCI scheduler, then we may still want to implement something like what Jeff described in the description.

Comment 5 by estaab@chromium.org, Mar 27 2017

In general we're trying to kill all of our one-off appengine apps.

What's the exact use case for this? Why are you regularly killing the WPT exporter? There are already other ways to disable a builder through CLs, e.g. at the recipe level. Does this need to be more dynamic than through a CL?
We aren't regularly killing the WPT exporter, I think it's more of a "just in case" thing (there was one issue before where it was repeatedly creating pull requests on GitHub...) I believe that it doesn't really need to be more dynamic than through a CL -- just that a web UI would be faster or more convenient.

Also: Vadim noted in  bug 705588  that the LUCI scheduler already supports pausing through a web UI, which is very cool.

Comment 7 by no...@chromium.org, Mar 27 2017

This bug is in Infra>Platform>Scheduler component. What does it request for from LUCI Scheduler besides  issue 705588 ?
Cc: -hinoka@chromium.org
Components: -Infra>Platform>Scheduler
Nothing - now updating :-)
Summary: [WPT Export] Document how to put the exporter in --dry-run mode with a CL if misbehaving (was: [WPT Export] Add a remote kill switch flippable by anyone in chrome-infra)
Thanks for the input everyone, in that case I'll document how to turn the exporter off with a CL.
Description: Show this description
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abd1360936725f296381ceb3c194307a29137c53

commit abd1360936725f296381ceb3c194307a29137c53
Author: Jeff Carpenter <jeffcarp@chromium.org>
Date: Thu Mar 30 00:46:10 2017

Add docs for WPT Exporter and explain how to disable it

Bug:  705561 ,  693821 
Change-Id: I682573698ac7c053c44962846744c510b88f4e18
Reviewed-on: https://chromium-review.googlesource.com/462042
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#460603}
[modify] https://crrev.com/abd1360936725f296381ceb3c194307a29137c53/docs/testing/web_platform_tests.md

Status: Fixed (was: Assigned)
Blocking: 707006
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment