New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705557 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

kevin: Unbalanced enable for IRQ 101 warning at bootup (cpuboost_init)

Project Member Reported by diand...@chromium.org, Mar 27 2017

Issue description

I booted and happened to notice this warning fly by one boot (many boots went by without seeing this):

[    3.745067] Unbalanced enable for IRQ 101
[    3.745085] ------------[ cut here ]------------
[    3.745091] WARNING: at /mnt/host/source/src/third_party/kernel/v4.4/kernel/irq/manage.c:513
[    3.745097] Modules linked in:
[    3.745099]
[    3.745110] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 4.4.52 #654
[    3.745114] Hardware name: Google Kevin (DT)
[    3.745122] task: ffffffc0cf6b0000 ti: ffffffc0cf6b8000 task.ti: ffffffc0cf6b8000
[    3.745137] PC is at __enable_irq+0x50/0xac
[    3.745146] LR is at __enable_irq+0x50/0xac
[    3.745153] pc : [<ffffffc0002a916c>] lr : [<ffffffc0002a916c>] pstate: 600000c5
[    3.745157] sp : ffffffc0cf6bbbd0
[    3.745167] x29: ffffffc0cf6bbbd0 x28: ffffffc0cd37b930
[    3.745177] x27: ffffffc0cd37b928 x26: ffffffc0cd37b91e
[    3.745187] x25: ffffffc0cd37b91c x24: ffffffc0cd37bb68
[    3.745197] x23: ffffffc0cd470208 x22: ffffffc0cd37bb28
[    3.745206] x21: 0000000000000065 x20: ffffffc0ce7f4e88
[    3.745216] x19: ffffffc0ce7f4e00 x18: 000000004bdecfa9
[    3.745225] x17: 00000000c4ac5665 x16: 0000000000000000
[    3.745233] x15: 00000000337ce6f6 x14: 0000000000000000
[    3.745242] x13: 0000000000000002 x12: 0000000000000003
[    3.745251] x11: 0000000000000000 x10: 00000000000008e0
[    3.745260] x9 : ffffff88002ac342 x8 : ffffffc001561a13
[    3.745269] x7 : 0000000000000000 x6 : 0000000000000000
[    3.745278] x5 : ffffff88002ac343 x4 : ffffff8819ed7003
[    3.745288] x3 : ffffffc0002a4bb0 x2 : cb88537fdc8ba634
[    3.745298] x1 : cb88537fdc8ba634 x0 : 000000000000001d
...
...
[    3.748162] ---[ end trace 9af5f3b737e3e538 ]---
[    3.748166] Call trace:
[    3.748177] [<ffffffc0002a916c>] __enable_irq+0x50/0xac
[    3.748188] [<ffffffc0002a924c>] enable_irq+0x84/0xac
[    3.748203] [<ffffffc00089baf4>] mxt_input_open+0x74/0x84
[    3.748214] [<ffffffc00087ddc0>] input_open_device+0xa4/0xfc
[    3.748228] [<ffffffc0009527f0>] cpuboost_input_connect+0x94/0xc4
[    3.748238] [<ffffffc00087ee38>] input_attach_handler+0x2bc/0x31c
[    3.748249] [<ffffffc00087fdb4>] input_register_handler+0xa8/0x100
[    3.748258] [<ffffffc001235d4c>] cpuboost_init+0x44/0x7c
[    3.748269] [<ffffffc00020120c>] do_one_initcall+0x1d0/0x1ec
[    3.748282] [<ffffffc001200eec>] kernel_init_freeable+0x2a0/0x358
[    3.748296] [<ffffffc000c110cc>] kernel_init+0x20/0xfc
[    3.748306] [<ffffffc0002045d0>] ret_from_fork+0x10/0x40

---

I haven't dug, since I'm currently digging into another bug.  However, this should probably be looked at.  

Full logs attached.

/proc/interrupts shows:
  101:          3          0          0          0          0          0  rockchip_gpio_irq   4 Edge      atmel_mxt_tp

Note that I _do not_ have ("UPSTREAM: pinctrl: rockchip: add irq_enable & irq_disable ops") in my local patches.

---

I'm on a kernel that's roughly this:

  9f416401b95d CHROMIUM: drm: rockchip: Add PSR residency debug entry

...but with a bunch of debugging patches atop.

 
170327-unbalancedirq-inputboost.txt
59.2 KB View Download
Components: OS>Kernel

Comment 2 by dtor@chromium.org, Apr 25 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2017

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/8ca2fbe6c75d627efc693ca603c6a75abb6ef33d

commit 8ca2fbe6c75d627efc693ca603c6a75abb6ef33d
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Fri May 19 01:07:59 2017

CHROMIUM: Input: atmel_mxt_ts - register interrupt before input device

We need to register interrupt before registering input device, otherwise
clients may try calling into mxt_open() which does enable_irq() and
disable_irq() on not-yet-registered IRQ.

BUG= chromium:705557 
TEST=Booted Kevin a few times, touchpad/touchscreen work, no spew in
dmesg.

Change-Id: I2e553bfdfbb11597f3517651c50e2007858e5e3d
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/503614
Commit-Ready: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/8ca2fbe6c75d627efc693ca603c6a75abb6ef33d/drivers/input/touchscreen/atmel_mxt_ts.c

Labels: -M-59 M-60
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in Chrome OS 9592.37.0, 60.0.3112.50. 

Sign in to add a comment