WebSocket: don't throw for bad ports |
|||||
Issue descriptionInstead, let the network layer handle all security checks and fail asynchronously. No need to duplicate them. Test: https://github.com/w3c/web-platform-tests/issues/5212.
,
Mar 28 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 29 2018
,
Aug 3
,
Aug 3
Looks like only Edge does what the test expects: https://wpt.fyi/results/websockets/Create-blocked-port.any.html
,
Aug 8
Issue 872252 has been merged into this issue.
,
Aug 8
Cool, here's a permalink showing Edge passing: https://wpt.fyi/results/websockets/Create-blocked-port.any.html?sha=edb72456b7
,
Sep 3
My main concern is that we won't be able to test port blocking from JS any more. I think we will need a new unit test for net::WebSocketChannel to compensate.
,
Sep 3
It'll still be testable, it should just fire an error event instead of throwing an exception. That's how Edge passes the tests :) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mkwst@chromium.org
, Mar 27 2017Labels: OS-Android OS-Chrome OS-Linux OS-Windows
Status: Available (was: Unconfirmed)