New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705534 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

WebSocket: don't throw for bad ports

Project Member Reported by annevank...@gmail.com, Mar 27 2017

Issue description

Instead, let the network layer handle all security checks and fail asynchronously. No need to duplicate them.

Test: https://github.com/w3c/web-platform-tests/issues/5212.
 

Comment 1 by mkwst@chromium.org, Mar 27 2017

Cc: tyoshino@chromium.org yhirano@chromium.org
Labels: OS-Android OS-Chrome OS-Linux OS-Windows
Status: Available (was: Unconfirmed)
tyoshino@, yhirano@: Would y'all mind triaging this? Might be as trivial as dropping the check in `DOMWebSocket::connect()` (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp?rcl=da4b23b1d2a82705f7f4fdfb6c9c8de00341c0af&l=331)?
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 28 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by ricea@chromium.org, Mar 29 2018

Labels: -Type-Bug -Hotlist-Recharge-Cold Type-Compat
Status: Available (was: Untriaged)
Owner: ricea@chromium.org
Status: Assigned (was: Available)
Labels: -Type-Compat Hotlist-Interop Type-Bug
Looks like only Edge does what the test expects:

https://wpt.fyi/results/websockets/Create-blocked-port.any.html
 Issue 872252  has been merged into this issue.
Cool, here's a permalink showing Edge passing:
https://wpt.fyi/results/websockets/Create-blocked-port.any.html?sha=edb72456b7
My main concern is that we won't be able to test port blocking from JS any more. I think we will need a new unit test for net::WebSocketChannel to compensate.
It'll still be testable, it should just fire an error event instead of throwing an exception. That's how Edge passes the tests :)

Sign in to add a comment