New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705520 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-04-10
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Initiator popup has broken layout when call stack is too long

Reported by zboron.l...@gmail.com, Mar 27 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.33 Safari/537.36

Steps to reproduce the problem:
1. Open Network tab in dev tools.
2. Initiate some network calls from javascript.
3. Move cursor to Initiator column for any captured request.
4. Chrome displays call stack which caused request.

What is the expected behavior?
Before Chrome 58, entire call stack was displayed. If stack was too long to fit popup, scrollbar was displayed.

What went wrong?
There is no scrollbar in popup and list continues beyond its end. If list goes beyond the bottom edge of monitor, there is no way to see remaining function calls in stack.

Did this work before? Yes 57

Chrome version: 58.0.3029.33  Channel: beta
OS Version: ubuntu 14.04
Flash Version:
 
screenshot.png
230 KB View Download
Labels: Needs-Triage-M58 Needs-Bisect

Comment 2 by hdodda@chromium.org, Mar 28 2017

Cc: hdodda@chromium.org
Labels: -Needs-Bisect -Needs-Triage-M58 hasbisect-per-revision ReleaseBlock-Stable M-59 OS-Mac OS-Windows
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Tested the issue on windows 7 , ubuntu 14.04 and amc os 10.12.3 using chrome M58 #58.0.3029.33 and issue is reproduced. Issue is not seen on current dev and canary chrome channels.
Hence provided the reverse bisect info.

Using the per-revision bisect providing the reverse bisect results,
Good build:59.0.3034.0 (Revision: 455336).
Bad build: 59.0.3033.0 (Revision: 455023).

You are probably looking for a change made after 455300 (known good), but no later than 455301 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspectas some perf builds might get missing due to failure.
 
https://chromium.googlesource.com/chromium/src/+log/35cb1d3e7a0b1ebe62b485ff06bf641a01d8c36a..72b6d79734c7fd5925b6f862c588229b0207afe6

From the CL above, assigning the issue to the concern owner 

@dgozman - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2712063002


Thanks!
Labels: Needs-Bisect
Thank you for the report and reverse bisect! Unfortunately, merging that CL to M58 is not feasible, as it was quite a large rewrite. We'll need a separate fix for M58.

Can we get a bisect between 444943 (good) and 455300 (bad) to find a revision which introduced an issue? That will help with producing a right fix.

Comment 4 by ajha@chromium.org, Mar 30 2017

Cc: alph@chromium.org ajha@chromium.org
Labels: -Pri-2 -Needs-Bisect -M-59 M-58 Pri-1
Bisected this as per C#3 to identify the CL that caused the regression.

Last good build: 58.0.3021.0
First bad build: 58.0.3022.0

Changelog:
==========
https://chromium.googlesource.com/chromium/src/+log/eff1b4e3dad26106e6840b0840ff3c39f7d7217f..8a213f053a3a7cbb2b09cc6a51bc26faf3e1da51

Review URL: https://codereview.chromium.org/2701403002
Able to reproduce the issue on windows 7 using chrome version 58.0.3029.41.

dgozman@ Could you please look into this stable blocker issue.


NextAction: 2017-04-10
A friendly reminder that M58 Stable launch is coming soon! Your bug is labelled as Stable ReleaseBlock, please make sure to land the fix, verified in trunk and get it merged into the release branch ASAP.
Unfortunately, fixing this on ToT is impossible - the code diverged a lot from the branch point, and the bug is long gone.

I have a high-risk fix directly on M58 branch: https://codereview.chromium.org/2807443002/.
Not sure it's worth a risk to fix directly on branch, giving the small bug surface (long-enough network initiators are rendered unreadable from some point). The workaround is to click on the first stack frame (that's always possible), set a breakpoint at that location and reload - callstack pane will show the full stack trace correctly.
A friendly reminder that M58 Stable is launch is coming soon (less than 2 weeks)! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
dgozman@ - Gentle Ping...!!
Could you please provide any latest update on this issue.

Thanks...!!
Status: WontFix (was: Assigned)
Per #c7, I don't think this is worth a risky merge to M58. Closing as WontFix.

Sign in to add a comment