New issue
Advanced search Search tips

Issue 705514 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
msramek@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

The metrics for 3rd party cookie blocking only include user actions

Project Member Reported by msramek@chromium.org, Mar 27 2017 
The actions "ThirdPartyCookieBlockingEnabled", "ThirdPartyCookieBlockingDisabled" are recorded in CookieSettingsFactory::BuildServiceInstanceFor() which happens before PreferenceAPIBase::SetExtensionControlledPref().

Therefore, users who block third-party cookies by installing an extension will be counted in the "Enabled" bucket. Instead, they should be counted in the "Disabled" bucket.

On the way, these actions should also be converted to a histogram.
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 28 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by msramek@chromium.org, Sep 6

Labels: Hotlist-Privacy
Status: Available (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78cb1e78eca913936709c308d5a8089fbf893dcc

commit 78cb1e78eca913936709c308d5a8089fbf893dcc
Author: Martin Šrámek <msramek@chromium.org>
Date: Tue Jan 08 17:05:03 2019

Improve the 3P cookie blocking and DNT histograms

The 3P cookie blocking setting had been recorded as a pair of user
actions. This was done correctly, however, readers often had trouble
interpreting the data as it didn't sum up to 100% on the Actions
dashboard due to Profiles that have been running for longer than a week.
A histogram is a better choice to record the state of a setting
(as opposed to a change thereof).

The DNT setting metric seems to have existed in the past, but is no longer
recorded anywhere. Reintroduce it.

Bug: 705514
Change-Id: Icc56b0ccd1f5b124afe38a50d8fe6070e1e856c4
Reviewed-on: https://chromium-review.googlesource.com/c/1397629
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620762}
[modify] https://crrev.com/78cb1e78eca913936709c308d5a8089fbf893dcc/chrome/browser/content_settings/cookie_settings_factory.cc
[modify] https://crrev.com/78cb1e78eca913936709c308d5a8089fbf893dcc/tools/metrics/actions/actions.xml
[modify] https://crrev.com/78cb1e78eca913936709c308d5a8089fbf893dcc/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment