Gerrit publishes draft comments when we click dry run |
||||
Issue descriptionWhat steps will reproduce the problem? (1) Add some comments to a cl but don't publish them yet. (2) Click CQ dry run. What is the expected result? It should start a dry run and the comments should not be published What happens instead? It starts a dry run but also publishes the comments.
,
Mar 27 2017
Good catch, this is definitely a regression from Rietveld and something we should fix before launch.
,
Apr 21 2017
https://gerrit-review.googlesource.com/104270 for API https://cl//153866696 for implementation
,
May 5 2017
The two CLs above are ready to land. Turns out they're not strictly necessary -- there was a backend bug causing drafts to be published even when the frontend selected 'KEEP'. Now that's been fixed, and failing to set an explicit value results in drafts being kept. But explicit is better than implicit, so I'd like to land them anyway. |
||||
►
Sign in to add a comment |
||||
Comment 1 by andyb...@chromium.org
, Mar 27 2017Owner: aga...@chromium.org
Status: Assigned (was: Untriaged)