New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705505 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

can't cast from tab

Project Member Reported by jochen@chromium.org, Mar 27 2017

Issue description

Trying to cast from tab to a GVC doesn't work on canary anymore. I see that I'm joining the VC, but nothing gets presented. Today, the bubble where you can select the meeting crashed (crash id https://crash.corp.google.com/browse?q=reportid=%277b5b66ff60000000%27) and it's in general not possible to stop casting either.

Chrome Canary 59.0.3050.0 on windows 10
 
Labels: Needs-Bisect
Owner: niklase@chromium.org
Status: Assigned (was: Untriaged)
Owner: sko...@chromium.org
Sounds like castouts, over to skonig@

Comment 4 by sko...@chromium.org, Mar 27 2017

Cc: mfo...@chromium.org jrw@chromium.org
joechen@, can you file feedback from Cast on this please?  To do that right-click on the Cast icon in the toolbar (after you've reproduced this issue) and choose to "Report an issue."  Make sure logs are included, and put your email address in the body of the report so that we can locate it quickly.  Please reply back here once that's done.

Comment 5 by mfo...@chromium.org, Mar 27 2017

Cc: sko...@chromium.org
Components: -Internals>Cast
Owner: sprang@chromium.org
This looks like a crash in the WebRTC simulcast code.  sprang@ has been in this recently.

Labels: Needs-Triage-M59

Comment 7 by w...@chromium.org, Mar 28 2017

Cc: milligan@chromium.org
+milligan: Tim, does this sound like the WebRTC / Cast-to-Hangouts issue you mentioned to me the other day?
Components: Internals>Cast
Labels: TE-NeedsTriageFromMTV

Comment 9 by sprang@chromium.org, Mar 28 2017

I've repro'd this. Seems to be trigger after renegotiation when screenshare simulcast experiment is turned on.
I'll roll it back while investigating.
I guess that means you no longer need me to file feedback?
No, I think I have what I need. Thanks!
Labels: -TE-NeedsTriageFromMTV -Needs-Bisect -Needs-Triage-M59
Removing other labels as per c#11.

Thank you!
Labels: -OS-Windows OS-All
Status: Fixed (was: Assigned)
Fix for crash bug was landed here: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+/90e3b7de4724e21e48f651a62e626fcc2b21b782
The code landed in chrome here: https://chromium.googlesource.com/chromium/src/+/6869066a6f9589b41fcb1857f25dfc9436ee69ef
...which was included from build 59.0.3057.0


Project Member

Comment 15 by bugdroid1@chromium.org, Apr 4 2017

Labels: merge-merged-58
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/5bb66b6e65e11c5031893f731b722d0d7f06c09c

commit 5bb66b6e65e11c5031893f731b722d0d7f06c09c
Author: ilnik <ilnik@webrtc.org>
Date: Tue Apr 04 19:15:14 2017

Use simulcast for screenshare only in conference mode

Also, don't crash if InitEncode fails for vp8.

BUG= chromium:705505 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.webrtc.org/2779163002
Cr-Commit-Position: refs/heads/master@{#17452}
(cherry picked from commit fe627f30cbd3b4e0665237c7f309973cbf15e30b)

Review-Url: https://codereview.webrtc.org/2795043004
Cr-Commit-Position: refs/branch-heads/58@{#16}
Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937}

[modify] https://crrev.com/5bb66b6e65e11c5031893f731b722d0d7f06c09c/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/5bb66b6e65e11c5031893f731b722d0d7f06c09c/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/5bb66b6e65e11c5031893f731b722d0d7f06c09c/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/5bb66b6e65e11c5031893f731b722d0d7f06c09c/webrtc/video/vie_encoder_unittest.cc

Cc: ilnik@chromium.org

Sign in to add a comment