Pass //web-platform-test/fetch tests. |
|||||
Issue descriptionStep 1: Import //fetch tests from Web Platform Tests. Step 2: Make failing tests pass. Step 3: Yay. These tests encompass things ranging from `fetch()` to `nosniff` to http caching. We're passing most tests, but failing more than a few. I haven't dug through the failures yet, but I'll at least get the tests landed so that we don't regress further. (Ryan, can you delegate this to someone who knows things about caching in //net? I imagine that will end up involved in one way or another.) CCing relevant folks.
,
Mar 29 2017
,
Mar 29 2017
,
Mar 30 2017
You also need to import at least /XMLHttpRequest/resources as well, as /fetch/api/response/response-trailer.html depends on it.
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e617fa946919277991e615907e2617872e423c6 commit 0e617fa946919277991e615907e2617872e423c6 Author: qyearsley <qyearsley@chromium.org> Date: Fri Apr 07 18:39:43 2017 Update test expectations for tests are recently not flaky. This change was made automatically with update-test-expectations. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=media/autoplay-muted.html,http/tests/inspector/service-workers/service-worker-manager.html,fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html,http/tests/inspector/resource-tree/resource-tree-non-unique-url.html,http/tests/inspector-enabled/console-stack-overflow-source-url.html,virtual/mojo-loading/http/tests/inspector-enabled/console-stack-overflow-source-url.html,virtual/mojo-loading/http/tests/security/link-crossorigin-preload-no-cors.html,http/tests/inspector/tracing/timeline-script-parse.html,http/tests/media/media-source/mediasource-seek-beyond-duration.html,virtual/mojo-loading/http/tests/media/media-source/mediasource-seek-beyond-duration.html,external/wpt/fetch/api/redirect/redirect-location-worker.html,external/wpt/fetch/api/redirect/redirect-location.html,external/wpt/fetch/api/redirect/redirect-origin-worker.html,external/wpt/fetch/api/request/request-cache-default-conditional.html,external/wpt/service-workers/service-worker/registration-iframe.https.html BUG= 691045 , 564403 ,651343, 581468 , 666628 ,664839, 678489 , 678490 ,705490, 697087 Review-Url: https://codereview.chromium.org/2800123002 Cr-Commit-Position: refs/heads/master@{#462938} [modify] https://crrev.com/0e617fa946919277991e615907e2617872e423c6/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bc8d44f3ab226674d0dd2c52ef631d6d52dc464 commit 5bc8d44f3ab226674d0dd2c52ef631d6d52dc464 Author: raphael.kubo.da.costa <raphael.kubo.da.costa@intel.com> Date: Wed Apr 12 15:06:27 2017 Import XMLHttpRequest wpt tests. Some Fetch API tests require bits from the /XMLHttpRequest directory. Some of the tests are also required for correctly testing behavior after changes to the Fetch and XHR specs. BUG= 687155 ,705490 R=falken@chromium.org,tyoshino@chromium.org,yhirano@chromium.org Review-Url: https://codereview.chromium.org/2808403003 Cr-Commit-Position: refs/heads/master@{#464024} [modify] https://crrev.com/5bc8d44f3ab226674d0dd2c52ef631d6d52dc464/third_party/WebKit/LayoutTests/W3CImportExpectations
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcbfde6ea277a07cddc3db613a3b4ff3de5d3933 commit fcbfde6ea277a07cddc3db613a3b4ff3de5d3933 Author: raphael.kubo.da.costa <raphael.kubo.da.costa@intel.com> Date: Wed Apr 19 08:58:44 2017 Fetch, XHR: Use ", " as header list value separator. Adapt to https://github.com/whatwg/fetch/pull/504 and https://github.com/whatwg/xhr/pull/130, which started requiring combined header list values to be separated by ", " instead of just ",". The XHR code handling responses already did that, but |ResourceRequest| and |FetchHeaderList| both had to be updated. As a bonus, this also makes us pass w-p-t's headers-combine.html. BUG= 700434 ,705490 R=mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org Review-Url: https://codereview.chromium.org/2822183002 Cr-Commit-Position: refs/heads/master@{#465537} [delete] https://crrev.com/14bcd90c3e83b60fb9ecce8504356b81af4c6209/third_party/WebKit/LayoutTests/external/wpt/fetch/api/headers/headers-combine-expected.txt [modify] https://crrev.com/fcbfde6ea277a07cddc3db613a3b4ff3de5d3933/third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js [modify] https://crrev.com/fcbfde6ea277a07cddc3db613a3b4ff3de5d3933/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js [modify] https://crrev.com/fcbfde6ea277a07cddc3db613a3b4ff3de5d3933/third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp [modify] https://crrev.com/fcbfde6ea277a07cddc3db613a3b4ff3de5d3933/third_party/WebKit/Source/modules/fetch/FetchHeaderListTest.cpp [modify] https://crrev.com/fcbfde6ea277a07cddc3db613a3b4ff3de5d3933/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37b22b3ee932500caa379e06b0a170cc164c8d03 commit 37b22b3ee932500caa379e06b0a170cc164c8d03 Author: raphael.kubo.da.costa <raphael.kubo.da.costa@intel.com> Date: Tue May 02 11:11:22 2017 fetch: Drop Headers from HeadersInit typedef declaration. This finally aligns our typedef with the version in the spec. We can do so now that our bindings code can convert any iterable object into a sequence. The Headers::FillWith(const Header*, ...) overload has been kept though, as it is used by other classes that may need to fill a Headers object with another existing one (when initializing a Request object, for example). BUG=705490 R=falken@chromium.org,mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org Review-Url: https://codereview.chromium.org/2854613002 Cr-Commit-Position: refs/heads/master@{#468595} [modify] https://crrev.com/37b22b3ee932500caa379e06b0a170cc164c8d03/content/browser/service_worker/service_worker_browsertest.cc [delete] https://crrev.com/ae5512e5d564f1a26e07c79bcc96bf2a27e68f5b/third_party/WebKit/LayoutTests/external/wpt/fetch/api/headers/headers-basic-expected.txt [modify] https://crrev.com/37b22b3ee932500caa379e06b0a170cc164c8d03/third_party/WebKit/Source/bindings/modules/v8/generated.gni [modify] https://crrev.com/37b22b3ee932500caa379e06b0a170cc164c8d03/third_party/WebKit/Source/modules/fetch/Headers.cpp [modify] https://crrev.com/37b22b3ee932500caa379e06b0a170cc164c8d03/third_party/WebKit/Source/modules/fetch/Headers.h [modify] https://crrev.com/37b22b3ee932500caa379e06b0a170cc164c8d03/third_party/WebKit/Source/modules/fetch/Headers.idl [modify] https://crrev.com/37b22b3ee932500caa379e06b0a170cc164c8d03/third_party/WebKit/Source/modules/fetch/RequestInit.cpp [modify] https://crrev.com/37b22b3ee932500caa379e06b0a170cc164c8d03/third_party/WebKit/Source/modules/fetch/RequestInit.h
,
May 2 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 7 2018
Currently existing failure expectation files, with the number of FAILs: 5 security/redirect-to-url-with-credentials.https-expected.txt 28 data-urls/processing.any-expected.txt 5 data-urls/base64.any-expected.txt 7 api/idl.any-expected.txt 5 api/redirect/redirect-location-expected.txt 1 api/redirect/redirect-empty-location-expected.txt 5 api/cors/cors-multiple-origins-expected.txt 10 api/cors/cors-preflight-redirect.any-expected.txt 4 api/request/request-disturbed-expected.txt 1 api/request/request-error-expected.txt 1 api/request/request-reset-attributes.https-expected.txt 1 api/request/request-keepalive-expected.txt 5 api/request/request-idl-expected.txt 1 api/request/request-consume-empty-expected.txt 1 api/headers/headers-record-expected.txt 1 api/response/response-trailer-expected.txt 10 api/response/response-error-from-stream-expected.txt 1 api/response/response-consume-empty-expected.txt 6 api/response/response-static-redirect-expected.txt 3 api/response/response-idl-expected.txt 12 api/response/response-clone-expected.txt 6 api/basic/request-upload.any-expected.txt 1 api/abort/general-serviceworker.https-expected.txt 1 api/abort/general.any-expected.txt 9 http-cache/invalidate-expected.txt 5 http-cache/partial-expected.txt 8 http-cache/cc-request-expected.txt 1 http-cache/vary-expected.txt 6 http-cache/heuristic-expected.txt See also https://wpt.fyi/fetch. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Mar 28 2017