Regression:Radio button became narrow for Huge font size |
|||||
Issue descriptionChrome Version: 59.0.3053.0 OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Launch chrome and navigate to the chrome://md-settings and customise font section (2)Increase the font size to maximum. (3)And observe the radio buttons in the start-up section(3rd radio button) Expected result:Radio button should not appear as narrow. Actual Result:Radio button appears narrow. This is regression issue broken in M-55 Manual bisect info: ====================== Good Build:55.0.2846.0 Bad Build:55.0.2847.0
,
Mar 28 2017
Narrow Bisect:: =============== Good::55.0.2846.0 -- (build revision 415833) Bad ::55.0.2847.0 -- (build revision 416149) After executing the per-revision bisect script , i got the following CL's between good and bad build versions =============================================== https://chromium.googlesource.com/chromium/src/+log/8ad01a3783fd1655ef91b93a62fb854951ba5e16..05b5db68bf23918ab865837f1720525e11f3c72f Review-Url: https://codereview.chromium.org/2297663003 dschuyler@ could you please look into this issue if it is related to your change,else please help us in finding the appropriate owner for this issue. Thanks,
,
Apr 7 2017
Added Polymer pull request at https://github.com/PolymerElements/paper-radio-button/pull/115
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ff1057b16a8d3bb219af78d9048f4245203155d commit 6ff1057b16a8d3bb219af78d9048f4245203155d Author: dschuyler <dschuyler@chromium.org> Date: Mon Apr 10 23:43:56 2017 [Polymer] paper-radio-button mixin This CL updates paper-radio-button with a mixin that allows for specific styling on the radio container. BUG= 705479 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2812593004 Cr-Commit-Position: refs/heads/master@{#463447} [modify] https://crrev.com/6ff1057b16a8d3bb219af78d9048f4245203155d/third_party/polymer/v1_0/bower.json [modify] https://crrev.com/6ff1057b16a8d3bb219af78d9048f4245203155d/third_party/polymer/v1_0/components-chromium/paper-radio-button/bower.json [modify] https://crrev.com/6ff1057b16a8d3bb219af78d9048f4245203155d/third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button.html [modify] https://crrev.com/6ff1057b16a8d3bb219af78d9048f4245203155d/third_party/polymer/v1_0/components_summary.txt
,
Apr 11 2017
,
Apr 12 2017
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03e0ed84b42ebd642fe7f517b2d8eda18ebb13e3 commit 03e0ed84b42ebd642fe7f517b2d8eda18ebb13e3 Author: dschuyler <dschuyler@chromium.org> Date: Wed Apr 12 18:15:24 2017 [MD settings] keep radio button circles circular This CL prevents the 'circle part' of a radio button from 'flex shrinking' when the label for the button gets too big (creating a kind of pressure on the radio button). BUG= 705479 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2809123004 Cr-Commit-Position: refs/heads/master@{#464089} [modify] https://crrev.com/03e0ed84b42ebd642fe7f517b2d8eda18ebb13e3/chrome/browser/resources/settings/settings_shared_css.html
,
Apr 12 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kavvaru@chromium.org
, Mar 27 2017Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)