'Classic' benchmarking configuration doesn't seem to be disabling I+TF |
|||||
Issue descriptionMichael, the -classic benchmark configuration doesn't seem to be disabling Ignition+Turbofan. If you look at the following graphs, -classic follows identically with the (currently I+TF) default pipeline. This shouldn't be the case (notice the big drops in each graph when I+TF was enabled). Could you take a look?
,
Mar 28 2017
Ross and me took a look into this. Passing --no-turbo to chrome does not disable Turbofan. So currently classic is running the same configuration as the default (Ignition + TurboFan). It could be because of the --future flag that is set later. I will look into it today.
,
Mar 29 2017
This is because of the V8Future configuration. After these cls: https://codereview.chromium.org/2747163004/ and https://codereview.chromium.org/2744293002/ V8Future will be enabled which enables --turbo. This happens after processing the command line flags, so --no-turbo does not have the intended affect. Ross would look into it by reverting the cls after setting up stabile finch trials.
,
Mar 29 2017
Sorry was/am sick. Thanks for catching and starting to resolving it.
,
Mar 29 2017
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/124254af04fd234fffa434b8b4380f5056528e3b commit 124254af04fd234fffa434b8b4380f5056528e3b Author: rmcilroy <rmcilroy@chromium.org> Date: Wed Mar 29 14:30:55 2017 Remove V8Future experiment. Removes the V8 Future experiment since it conflicts with the V8NoTurbo experiment and adds confusion as to how to enable / disable Ignition+ TurboFan. Also make the description for the V8NoTurbo about://flags entry clearer. BUG=chromium:703569, chromium:705476 Review-Url: https://codereview.chromium.org/2786633002 Cr-Commit-Position: refs/heads/master@{#460380} [modify] https://crrev.com/124254af04fd234fffa434b8b4380f5056528e3b/chrome/browser/about_flags.cc [modify] https://crrev.com/124254af04fd234fffa434b8b4380f5056528e3b/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/124254af04fd234fffa434b8b4380f5056528e3b/gin/gin_features.cc [modify] https://crrev.com/124254af04fd234fffa434b8b4380f5056528e3b/gin/public/gin_features.h [modify] https://crrev.com/124254af04fd234fffa434b8b4380f5056528e3b/gin/v8_initializer.cc
,
Mar 30 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rmcilroy@chromium.org
, Mar 27 2017