New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 705441 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dbeam@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary 'REMOVE ALL SHOWN' is seen for no search results of cookies in md-settings

Reported by sans...@etouch.net, Mar 27 2017 
Chrome Version: 59.0.3053.0 bba05f44fe583ffa69c22d36f91aaebe0ceea282-refs/heads/master@{#459685}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

Steps:
1. Launch Chrome and navigate to chrome://md-settings/content/cookies
2. Type any random keyword in 'Search cookies' field and observe

Actual: Unnecessary 'REMOVE ALL SHOWN' is seen and overlay also appear after clicking on it for no search results

Expected: 'REMOVE ALL SHOWN' should not be seen for no search results

This is regression issue, broken in ‘M 59’ and will soon update other info :

Good build:59.0.3042.0
Bad build: 59.0.3043.0
Actual_video.mov
2.7 MB Download
Expected_video.mov
1.8 MB Download

Comment 1 by rbasuvula@chromium.org, Mar 27 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3042.0 (Revision:456934).
Bad build:59.0.3043.0 (Revision:457297).

You are probably looking for a change made after 457183 (known good), but no later than 457184 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/99567cf4a49bc6e5b58b58ca3ace741194f08a8e..a46bc7937ac5efb5d990fb5c49c519b21e037403

From the CL above, assigning the issue to the concern owner

@dpapad : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2738063008
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3053.0

Comment 2 by dpa...@chromium.org, Mar 27 2017

Labels: -Pri-1 Proj-MaterialDesign-WebUI Pri-2
Status: Started (was: Assigned)

Comment 3 by dpa...@chromium.org, Mar 27 2017

Cc: dbeam@chromium.org
The addition of suppressTemplateNotifications config flag at [1], caused this regression. In theory should be fixed by adding the notify-dom-change attribute as done in [2], but it did not fix it. After further investigation, I think the culprit is on the Polymer side, see [3].

[1] https://codereview.chromium.org/2738063008
[2] https://codereview.chromium.org/2781703002
[3] https://github.com/Polymer/polymer/issues/4465

Comment 4 by tbuck...@chromium.org, Mar 27 2017

Labels: Hotlist-MD-Settings-Privacy-SiteSettings
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff5026c59eda509f6f73caee29a4b36042d2e4f9

commit ff5026c59eda509f6f73caee29a4b36042d2e4f9
Author: dpapad <dpapad@chromium.org>
Date: Tue Mar 28 20:47:50 2017

MD Settings: Fix case where 'REMOVE ALL SHOWN' button is erroneously shown.

BUG= 705441 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2781703002
Cr-Commit-Position: refs/heads/master@{#460214}

[modify] https://crrev.com/ff5026c59eda509f6f73caee29a4b36042d2e4f9/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/ff5026c59eda509f6f73caee29a4b36042d2e4f9/chrome/test/data/webui/settings/site_data_test.js

Comment 6 by dpa...@chromium.org, Mar 28 2017

Status: Fixed (was: Started)

Comment 7 by msrchandra@chromium.org, Apr 4 2017

Labels: TE-Verified-M59 TE-Verified-59.0.3061.3
Tested the issue on Latest Dev# 59.0.3061.3 on Windows & Mac and Dev# 59.0.3061.0 on Ubuntu and found the issue to be fixed.
Remove All Shown option is not seen. Hence adding TE-Verified labels.
Attaching screen cast for reference.
Thank You.
705441.ogv
2.0 MB View Download
►

Sign in to add a comment