New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705424 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in SkIRect::inset

Project Member Reported by ClusterFuzz, Mar 27 2017

Issue description

Cc: msrchandra@chromium.org
Components: Internals>GPU>Rasterization
Labels: Test-Predator-Correct-CLs M-59
Owner: bsalomon@chromium.org
Status: Assigned (was: Untriaged)
Assigning to the concern owner from Predator results --
The result is a list of CLs that change the crashed files. 

Author: Brian Salomon
Project: chromium-skia
Changelist: https://skia.googlesource.com/skia.git/+/859621fadbbbecf2dd40dc89f93f61bfb8ab6ead
Time: Thu Mar 16 09:21:54 2017 -0400
Lines 1756-1757 of file GrRenderTargetContext.cpp which potentially caused crash are changed in this cl (frame #3, "GrRenderTargetContext::addMeshDrawOp").
Minimum distance from crash line to modified line: 0. (file: GrRenderTargetContext.cpp, crashed on: 1756, modified: 1756).

@Brian -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Project Member

Comment 2 by ClusterFuzz, Aug 10 2017

ClusterFuzz has detected this issue as fixed in range 493136:493198.

Detailed report: https://clusterfuzz.com/testcase?key=5963000201871360

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  SkIRect::inset
  outset
  GrRenderTargetContext::setupDstTexture
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=456626:457730
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=493136:493198

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5963000201871360

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 3 by ClusterFuzz, Aug 10 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5963000201871360 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment