New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705417 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

45kb regression in resource_sizes (MonochromePublic.apk) at 459489:459489

Project Member Reported by toyoshim@chromium.org, Mar 27 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=705417

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrJebvgoM


Bot(s) for this bug's original alert(s):

Android Builder
Owner: agrieve@chromium.org
Status: Assigned (was: Untriaged)
Summary: 61kb regression in resource_sizes (MonochromePublic.apk) at 459489:459489 (was: 0.1% regression in resource_sizes (MonochromePublic.apk) at 459489:459489)
Caused by v8 roll:
https://chromium.googlesource.com/v8/v8/+log/8baea06f..417c83c1

53kb in native code, the rest in snapshot file.

I'll put together the per-commit sizes.
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Mar 27 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : resource_sizes
  Metric       : MonochromePublic.apk_Specifics/normalized apk size
  Change       : 0.08% | 75183558.0 -> 75245030.0

Suspected Commit Range
  33 commits in range
  https://chromium.googlesource.com/chromium/src/+log/42267f803ddaadca1d2d716a478ea5f8dd9f169f..c6aafdcefd3e6c7abcdc205d46c0c2a3e0c8be58


Revision                           Result               N
chromium@459488                    75183558 +- 0.0      6        good
chromium@459488,v8@2629f811ea      ---                  ---      build failure
---                                ---                  ---      too many build failures to list
chromium@459488,v8@417c83c1b1      ---                  ---      build failure
chromium@459489                    75245030 +- 0.0      6        bad

To Run This Test
  src/build/android/resource_sizes.py --chromium-output-directory {CHROMIUM_OUTPUT_DIR} --chartjson {CHROMIUM_OUTPUT_DIR}/apks/MonochromePublic.apk

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983985761784880624

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6623659466162176


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Owner: bradnelson@chromium.org
Summary: 45kb regression in resource_sizes (MonochromePublic.apk) at 459489:459489 (was: 61kb regression in resource_sizes (MonochromePublic.apk) at 459489:459489)
Here we go:

commit                                  	apk size	normalized	delta
2629f811ea2f784e810ea9a38c1d290097cfa8e3	48599674	71862331	
249001b4e9a59ff52fc1f9d9a3e89846a7fc19a1	48599910	71862331	0
bdf32cf1bc96982ff5a22195d874617ffae03e79	48599910	71862331	0
083a8d7209e4ee3e43bb03ae3bb2633177d4a77c	48624790	71907424	45093
16c38aa820521e2621ffd121977e93d912fbf2aa	48626454	71907420	-4
2458683f5542aeaa6ff0b32dc4d376c48dde4509	48626454	71907420	0
78ede2b1a3d16c37a6fe5a8ea0b48da633a1c9bf	48626454	71907420	0
30e5ec7253b56cc5c95cad2248043e519fa9bf2e	48626454	71907420	0
c152d459502ba6b6307611dd38221fa9daa53eb2	48627026	71907417	-3
b7ac3668ea76aa70116161c43a90d25559684dad	48627026	71907417	0
810e8593003c33c058cee7ad0fcd42c788cb5597	48627570	71907419	2
f764a5c8c0c973a1996b2f86e009b592771bd8c4	48625722	71907423	4
69e02958d31ac939db13f6e55ad1d62c1a57de3c	48632214	71915475	8052
c90ce431617d85a61d5fc07c3ee3bfb15e28be7d	48632214	71915475	0
0cfd2febcea9433bb856f7e729b2113c9f4e59c5	48632202	71915475	0
1ef7fcad8efdd9dc07e4b2bf7291f0e02b626f7d	48631014	71915476	1
f12b193df9134ba3a1ef565a8c799f19060205af	48631074	71915465	-11
dc00a1216f8e8f47742e95f5b44d76b4fe3e476b	48631074	71915465	0
15898daf7cc473c0296b0d754e483a0d5e296a42	48631074	71915465	0
4693a4337a5fdff6645786518e560cd476c765d8	48631398	71911380	-4085
c10cde195983dce0b88eeb533774a4fe14a8813f	48631386	71911377	-3
c769745d5856a7eb3a0dbe6af5376c7638944364	48630962	71911377	0
c9da6609283ab8bf92da6c1fa4d73cb6aa099122	48630962	71911377	0
8b8dfda8cfba652f5d9d21e44ce31f0478d08601	48630866	71911401	24
6141f6e2169f26d0606bee34e2ff9d680eac5d65	48636962	71920109	8708
d0c2b8c43f53fc237efad1e5b402922d09d8786b	48640486	71924205	4096
9a3b029b6c8ccf3792f162c7f79ceacc694aa0df	48640690	71924205	0
97300c5c38f775bdec197909e4140ce649c5713a	48640154	71923941	-264
565829f58027659b0cddc4c122042156fb01ad7b	48640154	71923941	0
885f0bc4a77692e5aa3b2c0cad0c9f5b3ada3796	48641654	71925452	1511
dae6e43d38c0f66a49f66cfd7eb2f7113f054e68	48642978	71925455	3
417c83c1b16e7efd18900da8c267b2ee6ee621f3	48642874	71925453	-2

Looks like the culprit is (adds 45kb):
http://crrev.com/083a8d7209e4ee3e43bb03ae3bb2633177d4a77c

Assigning to CL author for further investigation / comment.
For reference: here is the list of symbols that changed in that commit:

Section Sizes (Total=42,860 bytes):
.bss: 32 bytes (not included in totals)
.data: 32 bytes (0.1%)
.data.rel.ro: 0 bytes (0.0%)
.data.rel.ro.local: 0 bytes (0.0%)
.rodata: 3,072 bytes (7.2%)
.text: 39,756 bytes (92.8%)

96 symbols added (+), 20 changed (~), 2 removed (-), 312523 unchanged (not shown)
Showing 118 symbols with total size: 42768 bytes
First columns are: running total, type, size
+     3096 t@0xd892ac    3096    v8/v8_base/asm-scanner.o
+     3096                       v8::internal::AsmJsScanner::AsmJsScanner
~     6160 r@0x29248a0   3064    <no path>
~     6160                       ** merge strings
+     9096 t@0xd85440    2936    v8/v8_base/asm-parser.o
+     9096                       v8::internal::wasm::AsmJsParser::ValidateCall
+    10944 t@0xd829c0    1848    v8/v8_base/asm-parser.o
+    10944                       v8::internal::wasm::AsmJsParser::ValidateFunctionLocals
+    12160 t@0xd838c8    1216    v8/v8_base/asm-parser.o
+    12160                       v8::internal::wasm::AsmJsParser::MultiplicativeExpression
+    13288 t@0xd8418c    1128    v8/v8_base/asm-parser.o
+    13288                       v8::internal::wasm::AsmJsParser::RelationalExpression
+    14400 t@0xd867c4    1112    v8/v8_base/asm-parser.o
+    14400                       v8::internal::wasm::AsmJsParser::ValidateFunction
+    15484 t@0xd80e48    1084    v8/v8_base/asm-parser.o
+    15484                       v8::internal::wasm::AsmJsParser::InitializeStdlibTypes
+    16524 t@0xd825b0    1040    v8/v8_base/asm-parser.o
+    16524                       v8::internal::wasm::AsmJsParser::ValidateFunctionParams
+    17504 t@0xd834f4    980     v8/v8_base/asm-parser.o
+    17504                       v8::internal::wasm::AsmJsParser::UnaryExpression
+    18416 t@0xd84d64    912     v8/v8_base/asm-parser.o
+    18416                       v8::internal::wasm::AsmJsParser::AssignmentExpression
+    19300 t@0xd87aa8    884     v8/v8_base/asm-parser.o
+    19300                       v8::internal::wasm::AsmJsParser::ValidateModuleVarStdlib
+    20100 t@0xd88168    800     v8/v8_base/asm-parser.o
+    20100                       v8::internal::wasm::AsmJsParser::ValidateModuleVar
+    20876 t@0xd87768    776     v8/v8_base/asm-parser.o
+    20876                       v8::internal::wasm::AsmJsParser::SwitchStatement
+    21644 t@0xd8a0bc    768     v8/v8_base/asm-scanner.o
+    21644                       v8::internal::AsmJsScanner::Next [clone .part.56]
+    22412 t@0xd88554    768     v8/v8_base/asm-parser.o
+    22412                       v8::internal::wasm::AsmJsParser::ValidateModule
+    23120 t@0xd88c1c    708     v8/v8_base/asm-scanner.o
+    23120                       v8::internal::AsmJsScanner::ConsumeNumber
+    23820 t@0xd85fb8    700     v8/v8_base/asm-parser.o
+    23820                       v8::internal::wasm::AsmJsParser::ValidateHeapAccess
+    24448 t@0xd81efc    628     v8/v8_base/asm-parser.o
+    24448                       v8::internal::wasm::AsmJsParser::ValidateExport
+    25064 t@0xd8712c    616     v8/v8_base/asm-parser.o
+    25064                       v8::internal::wasm::AsmJsParser::ForStatement
+    25668 t@0xd86ed0    604     v8/v8_base/asm-parser.o
+    25668                       v8::internal::wasm::AsmJsParser::DoStatement
+    26248 t@0xd845f4    580     v8/v8_base/asm-parser.o
+    26248                       v8::internal::wasm::AsmJsParser::EqualityExpression
+    26820 t@0xd86588    572     v8/v8_base/asm-parser.o
+    26820                       v8::internal::wasm::AsmJsParser::ValidateStatement
+    27380 t@0xd82380    560     v8/v8_base/asm-parser.o
+    27380                       v8::internal::wasm::AsmJsParser::ValidateFunctionTable
+    27920 t@0xd87f4c    540     v8/v8_base/asm-parser.o
+    27920                       v8::internal::wasm::AsmJsParser::ValidateModuleVarImport
+    28448 t@0xd84b54    528     v8/v8_base/asm-parser.o
+    28448                       v8::internal::wasm::AsmJsParser::ConditionalExpression
+    28972 t@0xd83d88    524     v8/v8_base/asm-parser.o
+    28972                       v8::internal::wasm::AsmJsParser::AdditiveExpression
+    29476 t@0xd83f94    504     v8/v8_base/asm-parser.o
+    29476                       v8::internal::wasm::AsmJsParser::ShiftExpression
+    29948 t@0xd86cf8    472     v8/v8_base/asm-parser.o
+    29948                       v8::internal::wasm::AsmJsParser::WhileStatement
~    30404 t@0x165cef0   456     third_party/sfntly/libsfntly.a/generic_table_builder.o
~    30404                       ** symbol gap 4
+    30840 t@0xd81c6c    436     v8/v8_base/asm-parser.o
+    30840                       v8::internal::wasm::AsmJsParser::ValidateModuleVarFloat
+    31264 t@0xd89f14    424     v8/v8_base/asm-scanner.o
+    31264                       v8::internal::AsmJsScanner::ConsumeIdentifier
+    31680 t@0xd863e8    416     v8/v8_base/asm-parser.o
+    31680                       v8::internal::wasm::AsmJsParser::IfStatement
+    32088 t@0xd821a4    408     v8/v8_base/asm-parser.o
+    32088                       v8::internal::wasm::AsmJsParser::ValidateModuleVarNewStdlib
~    32484 t@0xd80484    396     v8/v8_base/asm-js.o
~    32484                       v8::internal::AsmJs::CompileAsmViaWasm
+    32856 t@0xd813c4    372     v8/v8_base/asm-parser.o
+    32856                       v8::internal::wasm::AsmJsParser::AddGlobalImport
+    33228 t@0xd86274    372     v8/v8_base/asm-parser.o
+    33228                       v8::internal::wasm::AsmJsParser::MemberExpression
+    33596 t@0xd87538    368     v8/v8_base/asm-parser.o
+    33596                       v8::internal::wasm::AsmJsParser::ValidateCase
+    33960 t@0xd83248    364     v8/v8_base/asm-parser.o
+    33960                       v8::internal::wasm::AsmJsParser::ValidateFloatCoercion
+    34324 t@0xd80520    364     v8/v8_base/asm-js.o
+    34324                       v8::internal::wasm::AsmJsParser::~AsmJsParser
+    34676 t@0xd81538    352     v8/v8_base/asm-parser.o
+    34676                       std::__ndk1::vector<v8::internal::wasm::AsmJsParser::VarInfo, v8::internal::zone_allocator<v8::internal::wasm::AsmJsParser::VarInfo> >::__append
+    35008 t@0xd84a08    332     v8/v8_base/asm-parser.o
+    35008                       v8::internal::wasm::AsmJsParser::BitwiseORExpression
+    35340 t@0xd819e8    332     v8/v8_base/asm-parser.o
+    35340                       v8::internal::wasm::AsmJsParser::ValidateModuleParameters [clone .part.28]
+    35664 t@0xd88abc    324     v8/v8_base/asm-scanner.o
+    35664                       v8::internal::AsmJsScanner::ConsumeCompareOrShift
+    35984 t@0xd81284    320     v8/v8_base/asm-parser.o
+    35984                       v8::internal::wasm::AsmJsParser::AsmJsParser
+    36304 t@0xd833b4    320     v8/v8_base/asm-parser.o
+    36304                       v8::internal::wasm::AsmJsParser::CallExpression
+    36620 t@0xd851e4    316     v8/v8_base/asm-parser.o
+    36620                       v8::internal::wasm::AsmJsParser::ReturnStatement
+    36932 t@0xd81b34    312     v8/v8_base/asm-parser.o
+    36932                       v8::internal::wasm::AsmJsParser::NumericLiteral
+    37240 t@0xd87e18    308     v8/v8_base/asm-parser.o
+    37240                       std::__ndk1::list<v8::internal::wasm::AsmJsParser::FunctionImportInfo, std::__ndk1::allocator<v8::internal::wasm::AsmJsParser::FunctionImportInfo> >::resize
~    37524 t@0x1156244   284     v8/v8_base/wasm-module-builder.o
~    37524                       v8::internal::wasm::WasmModuleBuilder::WriteTo const
+    37780 t@0xd87438    256     v8/v8_base/asm-parser.o
+    37780                       v8::internal::wasm::AsmJsParser::ExpressionStatement
+    38020 t@0xd80bf8    240     v8/v8_base/asm-parser.o
+    38020                       v8::internal::wasm::AsmJsParser::ConvertSignature
+    38260 t@0xd850f4    240     v8/v8_base/asm-parser.o
+    38260                       v8::internal::wasm::AsmJsParser::Expression
+    38492 t@0xd84838    232     v8/v8_base/asm-parser.o
+    38492                       v8::internal::wasm::AsmJsParser::BitwiseANDExpression
+    38724 t@0xd84920    232     v8/v8_base/asm-parser.o
+    38724                       v8::internal::wasm::AsmJsParser::BitwiseXORExpression
+    38944 t@0xd86c1c    220     v8/v8_base/asm-parser.o
+    38944                       v8::internal::wasm::AsmJsParser::Block
+    39164 t@0xd81e20    220     v8/v8_base/asm-parser.o
+    39164                       v8::internal::wasm::AsmJsParser::Identifier
+    39372 t@0xd85370    208     v8/v8_base/asm-parser.o
+    39372                       v8::internal::wasm::AsmJsParser::ParenthesizedExpression
+    39576 t@0xd88488    204     v8/v8_base/asm-parser.o
+    39576                       v8::internal::wasm::AsmJsParser::ValidateModuleVars
+    39768 t@0xd876a8    192     v8/v8_base/asm-parser.o
+    39768                       v8::internal::wasm::AsmJsParser::ValidateDefault
~    39956 t@0x1a5f7d8   188     components/policy/proto/libproto_internal.a/device_management_backend.pb.o
~    39956                       ** symbol gap 5
+    40144 t@0xd81698    188     v8/v8_base/asm-parser.o
+    40144                       v8::internal::wasm::AsmJsParser::GetVarInfo
+    40328 t@0xd81930    184     v8/v8_base/asm-parser.o
+    40328                       v8::internal::wasm::AsmJsParser::GatherCases
+    40500 t@0x1161f20   172     v8/v8_base/wasm-module-builder.o
+    40500                       std::__ndk1::vector<unsigned char, v8::internal::zone_allocator<unsigned char> >::__append
+    40668 t@0xd831a0    168     v8/v8_base/asm-parser.o
+    40668                       v8::internal::wasm::AsmJsParser::BreakStatement
+    40836 t@0xd830f8    168     v8/v8_base/asm-parser.o
+    40836                       v8::internal::wasm::AsmJsParser::ContinueStatement
~    40672 t@0x226909c   -164    third_party/WebKit/Source/core/layout/svg/libsvg.a/SVGTextQuery.o
~    40672                       ** symbol gap 7
+    40836 t@0xd87394    164     v8/v8_base/asm-parser.o
+    40836                       v8::internal::wasm::AsmJsParser::LabelledStatement
+    40992 t@0x1162090   156     v8/v8_base/wasm-module-builder.o
+    40992                       v8::internal::wasm::WasmModuleBuilder::AddGlobalImport
~    40840 t@0x1e5e508   -152    third_party/libwebp/libwebp_enc.a/picture_csp_enc.o
~    40840                       ** symbol gap 6
-    40688 t@0xe446a4    -152    v8/v8_base/effect-control-linearizer.o
-    40688                       std::__ndk1::vector<v8::internal::compiler::PendingEffectPhi, v8::internal::zone_allocator<v8::internal::compiler::PendingEffectPhi> >::__push_back_slow_path<v8::internal::compiler::PendingEffectPhi>
+    40840 t@0xd817c0    152     v8/v8_base/asm-parser.o
+    40840                       std::__ndk1::vector<v8::internal::wasm::AsmJsParser::BlockInfo, v8::internal::zone_allocator<v8::internal::wasm::AsmJsParser::BlockInfo> >::__push_back_slow_path<v8::internal::wasm::AsmJsParser::BlockInfo const&>
+    40984 t@0xd88a2c    144     v8/v8_base/asm-scanner.o
+    40984                       v8::internal::AsmJsScanner::ConsumeString
+    41120 t@0x1161fcc   136     v8/v8_base/wasm-module-builder.o
+    41120                       v8::internal::wasm::WasmFunctionBuilder::StashCode
~    41248 t@0x1159b10   128     v8/v8_base/wasm-module.o
~    41248                       InstantiationHelper::ProcessImports
+    41356 t@0xd81754    108     v8/v8_base/asm-parser.o
+    41356                       v8::internal::wasm::AsmJsParser::PeekCall
+    41452 t@0xd88994    96      v8/v8_base/asm-scanner.o
+    41452                       v8::internal::AsmJsScanner::ConsumeCComment
+    41532 t@0xd85320    80      v8/v8_base/asm-parser.o
+    41532                       v8::internal::wasm::AsmJsParser::ValidateExpression
+    41608 t@0xd818e4    76      v8/v8_base/asm-parser.o
+    41608                       v8::internal::wasm::AsmJsParser::Begin
+    41684 t@0xd80d58    76      v8/v8_base/asm-parser.o
+    41684                       v8::internal::wasm::AsmJsParser::FindBreakLabelDepth
+    41760 t@0xd80d0c    76      v8/v8_base/asm-parser.o
+    41760                       v8::internal::wasm::AsmJsParser::FindContinueLabelDepth
+    41836 t@0xd81898    76      v8/v8_base/asm-parser.o
+    41836                       v8::internal::wasm::AsmJsParser::Loop
+    41904 t@0xd89268    68      v8/v8_base/asm-scanner.o
+    41904                       std::__ndk1::unordered_map<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, int, std::__ndk1::hash<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > >, std::__ndk1::equal_to<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > >, std::__ndk1::allocator<std::__ndk1::pair<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const, int> > >::operator[]
+    41972 t@0xd88940    68      v8/v8_base/asm-scanner.o
+    41972                       v8::internal::AsmJsScanner::ResetLocals
+    42040 t@0xd8a3d8    68      v8/v8_base/asm-scanner.o
+    42040                       v8::internal::AsmJsScanner::Seek
+    42108 t@0xd8233c    68      v8/v8_base/asm-parser.o
+    42108                       v8::internal::wasm::AsmJsParser::SkipSemicolon
+    42176 t@0x1161814   68      v8/v8_base/wasm-module-builder.o
+    42176                       v8::internal::wasm::WasmFunctionBuilder::EmitWithVarInt
+    42240 t@0xd81858    64      v8/v8_base/asm-parser.o
+    42240                       v8::internal::wasm::AsmJsParser::BareBegin
+    42296 t@0xd889f4    56      v8/v8_base/asm-scanner.o
+    42296                       v8::internal::AsmJsScanner::ConsumeCPPComment
+    42348 t@0xd87a70    52      v8/v8_base/asm-parser.o
+    42348                       std::__ndk1::__hash_table<v8::internal::wasm::AsmTyper::StandardMember, std::__ndk1::hash<int>, std::__ndk1::equal_to<v8::internal::wasm::AsmTyper::StandardMember>, std::__ndk1::allocator<v8::internal::wasm::AsmTyper::StandardMember> >::__insert_unique<v8::internal::wasm::AsmTyper::StandardMember>
+    42400 t@0xd8a41c    52      v8/v8_base/asm-scanner.o
+    42400                       v8::internal::AsmJsScanner::SetStream
+    42452 t@0xd82170    52      v8/v8_base/asm-parser.o
+    42452                       v8::internal::wasm::AsmJsParser::EmptyStatement
~    42500 t@0xe74950    48      v8/v8_base/js-native-context-specialization.o
~    42500                       ** symbol gap 2
+    42548 t@0xd88910    48      v8/v8_base/asm-scanner.o
+    42548                       v8::internal::AsmJsScanner::Rewind
+    42584 t@0xd7e5b4    36      v8/v8_base/asm-js.o
+    42584                       std::__ndk1::__hash_table<std::__ndk1::__hash_value_type<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, int>, std::__ndk1::__unordered_map_hasher<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, std::__ndk1::__hash_value_type<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, int>, std::__ndk1::hash<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > >, true>, std::__ndk1::__unordered_map_equal<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, std::__ndk1::__hash_value_type<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, int>, std::__ndk1::equal_to<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > >, true>, std::__ndk1::allocator<std::__ndk1::__hash_value_type<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, int> > >::__deallocate [clone .isra.71]
-    42548 t@0x11fc994   -36     v8/src/inspector/inspector/wasm-translation.o
-    42548                       std::__ndk1::__hash_table<std::__ndk1::__hash_value_type<v8_inspector::String16, v8_inspector::WasmTranslation::TranslatorImpl*>, std::__ndk1::__unordered_map_hasher<v8_inspector::String16, std::__ndk1::__hash_value_type<v8_inspector::String16, v8_inspector::WasmTranslation::TranslatorImpl*>, std::__ndk1::hash<v8_inspector::String16>, true>, std::__ndk1::__unordered_map_equal<v8_inspector::String16, std::__ndk1::__hash_value_type<v8_inspector::String16, v8_inspector::WasmTranslation::TranslatorImpl*>, std::__ndk1::equal_to<v8_inspector::String16>, true>, std::__ndk1::allocator<std::__ndk1::__hash_value_type<v8_inspector::String16, v8_inspector::WasmTranslation::TranslatorImpl*> > >::__deallocate [clone .isra.83]
~    42584 t@0xd7f7d8    36      v8/v8_base/asm-js.o
~    42584                       v8::internal::AsmJs::InstantiateAsmWasm
+    42612 t@0xd88c00    28      v8/v8_base/asm-scanner.o
+    42612                       v8::internal::AsmJsScanner::IsIdentifierStart
+    42640 t@0xd8a3bc    28      v8/v8_base/asm-scanner.o
+    42640                       v8::internal::AsmJsScanner::Next
~    42664 d@0x2ee20d0   24      v8/v8_base/flags.o
~    42664                       rel.local._ZN2v88internal12_GLOBAL__N_15flagsE
+    42688 t@0xd80ce8    24      v8/v8_base/asm-parser.o
+    42688                       v8::internal::wasm::AsmJsParser::End
+    42708 t@0xd88854    20      v8/v8_base/asm-parser.o
+    42708                       v8::internal::wasm::AsmJsParser::Run
~    42724 t@0x68b654    16      skia/skia/SkPathOpsTSect.o
~    42724                       ** symbol gap 0
~    42708 t@0x1268b74   -16     components/autofill/content/common/mojo_interfaces/autofill_agent.mojom.o
~    42708                       ** symbol gap 3
+    42724 t@0xd88984    16      v8/v8_base/asm-scanner.o
+    42724                       v8::internal::AsmJsScanner::GetPosition const
+    42736 t@0xd80d00    12      v8/v8_base/asm-parser.o
+    42736                       v8::internal::wasm::AsmJsParser::BareEnd
~    42748 t@0x1156160   12      v8/v8_base/wasm-module-builder.o
~    42748                       v8::internal::wasm::WasmModuleBuilder::WasmModuleBuilder
~    42756 d@0x0         8       <no path>
~    42756                       ** aggregate padding of delta symbols
~    42751 r@0x0         -5      <no path>
~    42751                       ** aggregate padding of delta symbols
~    42755 t@0x0         4       <no path>
~    42755                       ** aggregate padding of delta symbols
~    42759 t@0xa80618    4       sql/sql/statement.o
~    42759                       ** symbol gap 1
~    42755 t@0xf77468    -4      v8/v8_base/flags.o
~    42755                       v8::internal::ComputeFlagListHash
+    42759 r@0x2b0f458   4       v8/v8_base/asm-parser.o
+    42759                       v8::internal::wasm::kWasmF32
+    42763 r@0x2b0f454   4       v8/v8_base/asm-parser.o
+    42763                       v8::internal::wasm::kWasmF64
+    42767 r@0x2b0f45c   4       v8/v8_base/asm-parser.o
+    42767                       v8::internal::wasm::kWasmI32
+    42768 r@0x2b1133d   1       v8/v8_base/flags.o
+    42768                       v8::internal::FLAGDEFAULT_fast_validate_asm
~    42768 b@0x0         31      <no path>
~    42768                       ** aggregate padding of delta symbols
+    42768 b@0x2f13aec   1       v8/v8_base/flags.o
+    42768                       v8::internal::FLAG_fast_validate_asm

Labels: -Restrict-View-Google
Cc: mstarzinger@chromium.org
This new parser is planned to replace the current validation and typing plumbing (which we will shortly be tearing out). This will also unblock removing a good bit other code. This is expected to get in by M60.
Let me know if you have concerns.
To be clear this about 1/3 the size of what it will replace (in addition to unblocking removal of other stuff).

Cc: agrieve@chromium.org
Status: WontFix (was: Assigned)
WontFix-ing since this is pretty old, and it seems like the new parser was an overall win for binary size, but cc-ing agrieve FYI.

Sign in to add a comment