New issue
Advanced search Search tips

Issue 705397 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.1%-3.2% regression in system_health.memory_mobile at 459451:459528

Project Member Reported by toyoshim@chromium.org, Mar 27 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 27 2017

Cc: ericrk@chromium.org
Owner: ericrk@chromium.org

=== Auto-CCing suspected CL author ericrk@chromium.org ===

Hi ericrk@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : ericrk
  Commit : 42267f803ddaadca1d2d716a478ea5f8dd9f169f
  Date   : Fri Mar 24 18:39:52 2017
  Subject: Re-enable shader disk cache on Adreno 4/5xx

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:malloc:effective_size_avg/load_games/load_games_lazors
  Change       : 2.99% | 21451824.0 -> 22092860.0

Revision             Result                  N
chromium@459472      21451824 +- 170382      6      good
chromium@459480      21424659 +- 106880      6      good
chromium@459484      21391248 +- 177618      6      good
chromium@459486      21604399 +- 319573      6      good
chromium@459487      21635788 +- 184961      6      good
chromium@459488      21975979 +- 113723      6      bad       <--
chromium@459504      22092860 +- 190788      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.lazors system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983987312744602192

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5796768337362944


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
erickrk: anything we can do about this regression at this point?

Comment 6 by ericrk@chromium.org, Sep 14 2017

Status: Fixed (was: Assigned)
Sorry, the change which caused this regression was reverted for other reasons. Closing this out.

Sign in to add a comment