New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705383 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.4%-2.5% regression in system_health.memory_mobile at 458881:459005

Project Member Reported by toyoshim@chromium.org, Mar 27 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 27 2017

Cc: ben@chromium.org
Owner: ben@chromium.org

=== Auto-CCing suspected CL author ben@chromium.org ===

Hi ben@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : ben
  Commit : 649b3edd4d074b63688f31671cf36ca7cb8ff53b
  Date   : Thu Mar 23 00:32:02 2017
  Subject: Begin to wean child processes off reliance on a persistent service_manager::Connection to the browser.

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/browse_news/browse_news_cnn
  Change       : 1.48% | 20145099.3333 -> 20444149.3333

Revision             Result                  N
chromium@458927      20145099 +- 332777      6      good
chromium@458947      20099197 +- 382333      6      good
chromium@458952      20083379 +- 248707      6      good
chromium@458953      20156472 +- 241331      6      good
chromium@458954      20457597 +- 193564      6      bad       <--
chromium@458955      20619872 +- 269244      6      bad
chromium@458957      20547742 +- 275742      6      bad
chromium@458966      20591235 +- 226327      6      bad
chromium@459005      20444149 +- 336108      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.cnn system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983989325981239408

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5810292652507136


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: WontFix (was: Assigned)
This mostly came down eventually.

Sign in to add a comment