New issue
Advanced search Search tips

Issue 705372 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 704775
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

18.5% regression in blink_perf.dom at 458380:458522

Project Member Reported by toyoshim@chromium.org, Mar 27 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=705372

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrPL06AoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 27 2017

Cc: jfernan...@igalia.com
Owner: jfernan...@igalia.com

=== Auto-CCing suspected CL author jfernandez@igalia.com ===

Hi jfernandez@igalia.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : jfernandez
  Commit : 7b60b0148294aa25648798b20bb527097c800baf
  Date   : Tue Mar 21 13:21:15 2017
  Subject: [css-align] Import the CSS Box Alignment tests from the CSSWG Test Suite

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : blink_perf.dom
  Metric       : select-multiple-add/select-multiple-add
  Change       : 3.30% | 4768.27531545 -> 4615.24116505

Revision             Result                  N
chromium@458379      4768.28 +- 67.3395      14      good
chromium@458385      4819.6 +- 46.6334       6       good
chromium@458386      4745.2 +- 39.5127       6       bad       <--
chromium@458387      4752.58 +- 26.0972      6       bad
chromium@458388      4744.34 +- 107.072      14      bad
chromium@458397      4742.08 +- 82.9815      9       bad
chromium@458415      4739.99 +- 74.7599      9       bad
chromium@458451      4676.8 +- 427.231       9       bad
chromium@458522      4615.24 +- 470.211      6       bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983990360270157552

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5208560083927040


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
The CL 7b60b0148294aa25648798b20bb527097c800bafis just an import of some WPT tests, so it doesn't change any line of code. I don't see how how it may cause any performance regression.
The metric seems to bump down over two runs. Kicked off a bisect on a wider range.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Mar 27 2017

Mergedinto: 704775
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : rune
  Commit : df2ef06a75aae87d449e2f801e90fd418679871b
  Date   : Tue Mar 21 22:13:56 2017
  Subject: Updating :in-range should not rely on validation.

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : blink_perf.dom
  Metric       : select-multiple-add/select-multiple-add
  Change       : 19.39% | 4771.88918425 -> 3846.73358564

Revision             Result                  N
chromium@458379      4771.89 +- 24.373       6      good
chromium@458500      4759.12 +- 44.0726      6      good
chromium@458561      4686.82 +- 146.706      6      good
chromium@458569      4696.12 +- 90.7043      6      good
chromium@458573      4683.87 +- 87.1598      6      good
chromium@458575      4696.93 +- 41.8497      6      good
chromium@458576      3834.53 +- 160.092      6      bad       <--
chromium@458591      3840.79 +- 52.9744      6      bad
chromium@458621      3846.73 +- 31.5771      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983963152342743008

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5239262926077952


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Sign in to add a comment