Regression : In devtools toolbar, gray highlight is not seen properly on 'Chevron' icon.
Reported by
avsha...@etouch.net,
Mar 27 2017
|
||||
Issue descriptionChrome Version : 59.0.3053.0 (Official Build) bba05f44fe583ffa69c22d36f91aaebe0ceea282-refs/heads/master@{#459685} 32/64 bit OS : Windows (7,8,10), Mac (10.11.6, 10.12.1, 10.12) What steps will reproduce the problem? 1. Launch chrome and open devtools on NTP. 2. Hover mouse on 'Chevron icon' (>>) seen on the devtools toolbar and observe the gray highlight on chevron icon. Actual : On mouse hover, gray highlight for chevron icon is not seen properly (i.e a small gap is observed below Chevron icon, on mouse hover) Expected : On mouse hover, gray highlight for chevron icon should be seen properly. This is a regression issue broken in ‘M-59’, below is the Manual Regression range and will soon update other info. Good build : 59.0.3050.0 Bad build : 59.0.3051.3 Note : Will soon update other info once the build #59.0.3051.3 for Linux OS is available.
,
Mar 27 2017
Using the per-revision bisect providing the bisect results, Good build:59.0.3050.0 (Revision:459323). Bad build:59.0.3051.3 (Revision:459592). You are probably looking for a change made after 459460 (known good), but no later than 459461 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/6dd2a7f1f41fb4bfa416073ef276f1142e7c8ca8..0b9720c2eb9ba96fb1ca3a22a721ae0bd0b6a25a From the CL above, assigning the issue to the concern owner @lushnikov : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2775733002 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3053.0
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff3b9813827f6a237045257e87ad4f9711caf9e0 commit ff3b9813827f6a237045257e87ad4f9711caf9e0 Author: lushnikov <lushnikov@chromium.org> Date: Tue Mar 28 03:33:20 2017 DevTools: perfectly center shevron icon This patch: - centers shevron icon inside its spritesheet (largeIcons.svg) - centers icon inside its container div BUG= 705371 R=dgozman Review-Url: https://codereview.chromium.org/2782513002 Cr-Commit-Position: refs/heads/master@{#459999} [modify] https://crrev.com/ff3b9813827f6a237045257e87ad4f9711caf9e0/third_party/WebKit/Source/devtools/front_end/Images/largeIcons.png [modify] https://crrev.com/ff3b9813827f6a237045257e87ad4f9711caf9e0/third_party/WebKit/Source/devtools/front_end/Images/largeIcons_2x.png [modify] https://crrev.com/ff3b9813827f6a237045257e87ad4f9711caf9e0/third_party/WebKit/Source/devtools/front_end/Images/src/largeIcons.svg [modify] https://crrev.com/ff3b9813827f6a237045257e87ad4f9711caf9e0/third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes [modify] https://crrev.com/ff3b9813827f6a237045257e87ad4f9711caf9e0/third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes [modify] https://crrev.com/ff3b9813827f6a237045257e87ad4f9711caf9e0/third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css
,
Mar 28 2017
Thank you for the bugreport; should be fixed now.
,
Apr 4 2017
Verified the the issue on windows 7 , mac os 10.12.2 using chrome M59 #59.0.3061.3 and issue is fixed. Due to the build failure on linux , verified the issue on ubuntu 14.04 using chrome M59 #59.0.3061.0 and issue is fixed. On mouse hover, gray highlight for chevron icon is seen properly. Attached screenshot for reference. Adding Te-Verified labels. Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by avsha...@etouch.net
, Mar 27 2017